Re: [PATCH] media: imx283: drop CENTERED_RECTANGLE due to clang failure

[Mauro Carvalho Chehab <mchehab+huawei@kernel.org>]

Em Thu, 13 Jun 2024 15:43:04 +0000
Sakari Ailus <sakari.ailus@linux.intel.com> escreveu:

> Hi Kieran, Hans,
> 
> Thanks for working on this.
> 
> On Thu, Jun 13, 2024 at 04:26:43PM +0100, Kieran Bingham wrote:
> > Quoting Hans Verkuil (2024-06-13 16:19:08)  
> > > The CENTERED_RECTANGLE define fails to compile on clang and old gcc
> > > versions. Just drop it and fill in the crop rectangles explicitly.  
> > 
> > So back when I was playing around with this I thought it would have got
> > dropped during review / upstreaming before now - because I couldn't find
> > a way to make sure the macro args were guaranteed to be used only once,
> > by putting some locals in the macro (because of the initialisation).
> > 
> > So I'm not surprised that it needs to be removed, but I am surprised
> > that it wasn't for the reason I expected ;-)
> > 
> > Anyway - maybe later I'll experiement with more common helpers perhaps -
> > but not if it hits compile errors..  
> 
> Or once clang before ~ 17 is deprecated? :-)


It is not deprecated for Kernel builds. See Documentation/process/changes.rst:

<snip>
Current Minimal Requirements
****************************

Upgrade to at **least** these software revisions before thinking you've
encountered a bug!  If you're unsure what version you're currently
running, the suggested command should tell you.

Again, keep in mind that this list assumes you are already functionally
running a Linux kernel.  Also, not all tools are necessary on all
systems; obviously, if you don't have any PC Card hardware, for example,
you probably needn't concern yourself with pcmciautils.

====================== ===============  ========================================
        Program        Minimal version       Command to check the version
====================== ===============  ========================================
GNU C                  5.1              gcc --version
Clang/LLVM (optional)  13.0.1           clang --version
</snip>

Regards,
Mauro


Thanks,
Mauro