All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Somalapuram Amaranath" <Amaranath.Somalapuram@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v4 12/12] drm/xe: Increase the XE_PL_TT watermark
Date: Fri, 14 Jun 2024 12:25:48 +0200	[thread overview]
Message-ID: <20240614102548.4364-13-thomas.hellstrom@linux.intel.com> (raw)
In-Reply-To: <20240614102548.4364-1-thomas.hellstrom@linux.intel.com>

The XE_PL_TT watermark was set to 50% of system memory.
The idea behind that was unclear since the net effect is that
TT memory will be evicted to TTM_PL_SYSTEM memory if that
watermark is exceeded, requiring PPGTT rebinds and dma
remapping. But there is no similar watermark for TTM_PL_SYSTEM
memory.

The TTM functionality that tries to swap out system memory to
shmem objects if a 50% limit of total system memory is reached
is orthogonal to this, and with the shrinker added, it's no
longer in effect.

Replace the 50% TTM_PL_TT limit with a 100% limit, in effect
allowing all graphics memory to be bound to the device unless it
has been swapped out by the shrinker.

Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_ttm_sys_mgr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
index 9844a8edbfe1..d38b91872da3 100644
--- a/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
+++ b/drivers/gpu/drm/xe/xe_ttm_sys_mgr.c
@@ -108,9 +108,8 @@ int xe_ttm_sys_mgr_init(struct xe_device *xe)
 	u64 gtt_size;
 
 	si_meminfo(&si);
+	/* Potentially restrict amount of TT memory here. */
 	gtt_size = (u64)si.totalram * si.mem_unit;
-	/* TTM limits allocation of all TTM devices by 50% of system memory */
-	gtt_size /= 2;
 
 	man->use_tt = true;
 	man->func = &xe_ttm_sys_mgr_func;
-- 
2.44.0


  parent reply	other threads:[~2024-06-14 10:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 10:25 [PATCH v4 00/12] TTM shrinker helpers and xe buffer object shrinker Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 01/12] drm/ttm: Allow TTM LRU list nodes of different types Thomas Hellström
2024-06-15  7:45   ` kernel test robot
2024-06-14 10:25 ` [PATCH v4 02/12] drm/ttm: Slightly clean up LRU list iteration Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 03/12] drm/ttm: Use LRU hitches Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 04/12] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 05/12] drm/ttm: Provide a generic LRU walker helper Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 06/12] drm/ttm: Use the LRU walker helper for swapping Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 07/12] drm/ttm: Use the LRU walker for eviction Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 08/12] drm/ttm: Add a virtual base class for graphics memory backup Thomas Hellström
2024-06-17 14:09   ` Dan Carpenter
2024-06-14 10:25 ` [PATCH v4 09/12] drm/ttm/pool: Provide a helper to shrink pages Thomas Hellström
2024-06-15 10:55   ` kernel test robot
2024-06-14 10:25 ` [PATCH v4 10/12] drm/ttm: Use fault-injection to test error paths Thomas Hellström
2024-06-14 10:25 ` [PATCH v4 11/12] drm/ttm, drm/xe: Add a shrinker for xe bos Thomas Hellström
2024-06-14 23:27   ` kernel test robot
2024-06-14 10:25 ` Thomas Hellström [this message]
2024-06-14 12:00 ` ✓ CI.Patch_applied: success for TTM shrinker helpers and xe buffer object shrinker (rev4) Patchwork
2024-06-14 12:00 ` ✗ CI.checkpatch: warning " Patchwork
2024-06-14 12:01 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614102548.4364-13-thomas.hellstrom@linux.intel.com \
    --to=thomas.hellstrom@linux.intel.com \
    --cc=Amaranath.Somalapuram@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.