All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Fabio <pedretti.fabio@gmail.com>
Subject: [nf-next PATCH v2 0/2] netfilter: xt_recent: Allow for larger hitcount values
Date: Fri, 14 Jun 2024 17:16:39 +0200	[thread overview]
Message-ID: <20240614151641.28885-1-phil@nwl.cc> (raw)

Changes since v1:
- Do not support insanely large hitcount values to limit the amount of
  storage allocated per entry
- Fix typo in subject of patch 1

Patch 2 lifts the restriction of 255 as max hitcount value by adjusting
XT_RECENT_MAX_NSTAMPS value and increasing required struct field sizes
accordingly.

In struct recent_entry, field 'nstamps' was 16bit in size of unclear
reasons. Patch 1 changes that to match field 'index' providing rationale
why it is sufficient, thus paving the way for keeping both at 16bit (and
avoiding a larger size for 'nstamps').

Phil Sutter (2):
  netfilter: xt_recent: Reduce size of struct recent_entry::nstamps
  netfilter: xt_recent: Lift restrictions on max hitcount value

 net/netfilter/xt_recent.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.43.0


             reply	other threads:[~2024-06-14 15:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 15:16 Phil Sutter [this message]
2024-06-14 15:16 ` [nf-next PATCH v2 1/2] netfilter: xt_recent: Reduce size of struct recent_entry::nstamps Phil Sutter
2024-06-26 16:12   ` Pablo Neira Ayuso
2024-06-26 22:40     ` Phil Sutter
2024-06-26 23:39       ` Pablo Neira Ayuso
2024-06-27  0:06         ` Phil Sutter
2024-06-14 15:16 ` [nf-next PATCH v2 2/2] netfilter: xt_recent: Lift restrictions on max hitcount value Phil Sutter
2024-06-14 15:24   ` Pablo Neira Ayuso
2024-06-14 15:58     ` Fabio Pedretti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240614151641.28885-1-phil@nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pedretti.fabio@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.