From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 081E9C27C6E for ; Sat, 15 Jun 2024 00:56:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9FB7240390; Sat, 15 Jun 2024 00:56:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kwapKLUR6PoF; Sat, 15 Jun 2024 00:56:05 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6EC204026F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1718412965; bh=YfYPUr/6LuapLFsubEiJTpy9n4+3ednBXu0OlJpdbYA=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jDHj+9bVloRomlsb8mkKF65pfKnClVmn7pK9oQQ9RtiR2Qu+bh5t55FZgVov1mJVm R4ApD61aapE8Ew7DL7dFf9VzRcwzcV1rHMxfDsuhjNSVHcE+xSL3VXP+GAhl/3hNaw +29D7hGw6rR1YMiIj1DJu9PtkwTkMtakgDKu2LUHGLH2sQhSMa/wlapSAX8C2dy6XK iATPW1eRXg/jpYbr9JIzLSPvbjJ6Qmw8wQxhZZNQthFsmVnnvwQnH9SttNjunAV/QB 7cxY9wa9kY53qzBxaY3hkO8wkwkwu5JFMsVCBSmlXyd3n+6YiDlZxIkAmELXk4K1eR HiSJZiKKPDitQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 6EC204026F; Sat, 15 Jun 2024 00:56:05 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 0E5F71BF969 for ; Sat, 15 Jun 2024 00:56:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EE3B2416F3 for ; Sat, 15 Jun 2024 00:56:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 8O57eaKPx6G5 for ; Sat, 15 Jun 2024 00:56:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5DDDA416DB DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5DDDA416DB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5DDDA416DB for ; Sat, 15 Jun 2024 00:56:02 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0327C61F11; Sat, 15 Jun 2024 00:56:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF6BC2BD10; Sat, 15 Jun 2024 00:56:00 +0000 (UTC) Date: Fri, 14 Jun 2024 17:55:59 -0700 From: Jakub Kicinski To: Anil Samal Message-ID: <20240614175559.4826e4aa@kernel.org> In-Reply-To: <20240614125935.900102-4-anil.samal@intel.com> References: <20240614125935.900102-1-anil.samal@intel.com> <20240614125935.900102-4-anil.samal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718412960; bh=vfiMJ+3bv9cpjQwDMNPWKxLpb+EofwsYQJo95zaXp64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kjjpjnkjY9tlL41Ve5eD4jCTycckrdnRIZxucfFPAp/AeS3qjaBPfiiWaV1duYmmI K3k9huH1xTmXH6ft8YQ0wYl1/uGNmOQ8SIARGjua2llxv02O7eJQIfx8CfZZw6mvcE R1sOHv2d5pCJnEwIC0X1ihfP2DEEPaxh2K5qUp+WMoP2GzdgOazyBHh0g+yEFJf7OA RQMaAzJ68H2b3kGWqn3zXZEL8W4wZrrdfMS/U67xRR0M/lyZaE/NJ+1Fy7UCSPCGqC VCGpPim0ViLOpgEigG80R+kFe1ho3e7e236VOpY0lrYGDGKbPrtwPh0L+n5I2N6Bi5 ym0JCAnAiRRzQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=kjjpjnkj Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, lukasz.czapnik@intel.com, leszek.pepiak@intel.com, anthony.l.nguyen@intel.com, Simon Horman , przemyslaw.kitszel@intel.com, intel-wired-lan@lists.osuosl.org Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > To debug link issues in the field, serdes Tx/Rx equalizer values > help to determine the health of serdes lane. > > Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. > The following list of equalizer param is supported > a. rx_equalization_pre2 > b. rx_equalization_pre1 > c. rx_equalization_post1 > d. rx_equalization_bflf > e. rx_equalization_bfhf > f. rx_equalization_drate > g. tx_equalization_pre1 > h. tx_equalization_pre3 > i. tx_equalization_atten > j. tx_equalization_post1 > k. tx_equalization_pre2 I'd be tempted to create a dedicated way to dump vendor specific signal quality indicators (both for Ethernet and PCIe). Feels little cleaner than appending to a flat mixed-purpose dump. But either way is fine by me, TBH. Much better than vendor tools poking into the BAR... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EC6A7E6 for ; Sat, 15 Jun 2024 00:56:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718412961; cv=none; b=MnbANFdSLzsrNH0fGj99xAUa06Y55q9vEyMLpren5KJBMRSMmZ/cuuyL2j9rX9zfEkTdE31hdR0aUnoaA2wenZXEyNEujl6R/XmgW5u43Bx+4V391RBRBX9DzweamkMgHS5G/MYh32nd1w8Zr0nxztrSrF1PNN4WGmH8ZwfwSvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718412961; c=relaxed/simple; bh=vfiMJ+3bv9cpjQwDMNPWKxLpb+EofwsYQJo95zaXp64=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J32SZ5scCBegEtfuerdu0SC7+kkE0hoNJv0S0k3jUlAFjOsPo/Ktv4WfHecI6DgPOBBFno13ywOk/lQcTnHtYm10+kzkVLIw5TZV9ssBi3J8/cGGyq9NdHAYm4mIEm+2j9SMxNCsteUnob02+Bl49omDzAoFPBpz4NInc8/7AJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kjjpjnkj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kjjpjnkj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CF6BC2BD10; Sat, 15 Jun 2024 00:56:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718412960; bh=vfiMJ+3bv9cpjQwDMNPWKxLpb+EofwsYQJo95zaXp64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kjjpjnkjY9tlL41Ve5eD4jCTycckrdnRIZxucfFPAp/AeS3qjaBPfiiWaV1duYmmI K3k9huH1xTmXH6ft8YQ0wYl1/uGNmOQ8SIARGjua2llxv02O7eJQIfx8CfZZw6mvcE R1sOHv2d5pCJnEwIC0X1ihfP2DEEPaxh2K5qUp+WMoP2GzdgOazyBHh0g+yEFJf7OA RQMaAzJ68H2b3kGWqn3zXZEL8W4wZrrdfMS/U67xRR0M/lyZaE/NJ+1Fy7UCSPCGqC VCGpPim0ViLOpgEigG80R+kFe1ho3e7e236VOpY0lrYGDGKbPrtwPh0L+n5I2N6Bi5 ym0JCAnAiRRzQ== Date: Fri, 14 Jun 2024 17:55:59 -0700 From: Jakub Kicinski To: Anil Samal Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, leszek.pepiak@intel.com, przemyslaw.kitszel@intel.com, lukasz.czapnik@intel.com, anthony.l.nguyen@intel.com, Simon Horman , Jesse Brandeburg Subject: Re: [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values Message-ID: <20240614175559.4826e4aa@kernel.org> In-Reply-To: <20240614125935.900102-4-anil.samal@intel.com> References: <20240614125935.900102-1-anil.samal@intel.com> <20240614125935.900102-4-anil.samal@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > To debug link issues in the field, serdes Tx/Rx equalizer values > help to determine the health of serdes lane. > > Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. > The following list of equalizer param is supported > a. rx_equalization_pre2 > b. rx_equalization_pre1 > c. rx_equalization_post1 > d. rx_equalization_bflf > e. rx_equalization_bfhf > f. rx_equalization_drate > g. tx_equalization_pre1 > h. tx_equalization_pre3 > i. tx_equalization_atten > j. tx_equalization_post1 > k. tx_equalization_pre2 I'd be tempted to create a dedicated way to dump vendor specific signal quality indicators (both for Ethernet and PCIe). Feels little cleaner than appending to a flat mixed-purpose dump. But either way is fine by me, TBH. Much better than vendor tools poking into the BAR...