From: Jakub Kicinski <kuba@kernel.org>
To: Kamal Heib <kheib@redhat.com>
Cc: netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to fill stats strings
Date: Fri, 14 Jun 2024 18:37:52 -0700 [thread overview]
Message-ID: <20240614183752.707c4162@kernel.org> (raw)
In-Reply-To: <20240613184333.1126275-4-kheib@redhat.com>
On Thu, 13 Jun 2024 14:43:33 -0400 Kamal Heib wrote:
> Use the ethtool_puts/ethtool_sprintf helper to print the stats strings
> into the ethtool strings interface.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
minor build issue with this one:
drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:453:6: warning: unused variable 'index' [-Wunused-variable]
453 | int index = 0;
| ^~~~~
otherwise LGTM!
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-15 1:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 18:43 [PATCH net-next 0/3] net/mlx4_en: Use ethtool_puts/sprintf Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 1/3] net/mlx4_en: Use ethtool_puts to fill priv flags strings Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 2/3] net/mlx4_en: Use ethtool_puts to fill selftest strings Kamal Heib
2024-06-13 18:43 ` [PATCH net-next 3/3] net/mlx4_en: Use ethtool_puts/sprintf to fill stats strings Kamal Heib
2024-06-15 1:37 ` Jakub Kicinski [this message]
2024-06-17 5:06 ` Tariq Toukan
2024-06-17 17:20 ` Kamal Heib
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614183752.707c4162@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kheib@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.