From: Jakub Kicinski <kuba@kernel.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: netdev@vger.kernel.org, jeroendb@google.com,
pkaligineedi@google.com, shailend@google.com,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
willemb@google.com, hramamurthy@google.com, rushilg@google.com,
horms@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/5] gve: Add flow steering device option
Date: Fri, 14 Jun 2024 19:22:09 -0700 [thread overview]
Message-ID: <20240614192209.7c69df0b@kernel.org> (raw)
In-Reply-To: <20240613014744.1370943-4-ziweixiao@google.com>
On Thu, 13 Jun 2024 01:47:42 +0000 Ziwei Xiao wrote:
> + if (dev_op_flow_steering &&
> + (supported_features_mask & GVE_SUP_FLOW_STEERING_MASK)) {
> + if (dev_op_flow_steering->max_flow_rules) {
> + priv->max_flow_rules =
> + be32_to_cpu(dev_op_flow_steering->max_flow_rules);
> + dev_info(&priv->pdev->dev,
> + "FLOW STEERING device option enabled with max rule limit of %u.\n",
> + priv->max_flow_rules);
There's a print to the kernel logs every time driver loads to tell
the user flow steering is available...
> - /* DQO supports LRO. */
> if (!gve_is_gqi(priv))
> - priv->dev->hw_features |= NETIF_F_LRO;
> + priv->dev->hw_features |= NETIF_F_LRO | NETIF_F_NTUPLE;
Yet the uAPI feature which is supposed to let the user know its
supported appears to be set unconditionally.
next prev parent reply other threads:[~2024-06-15 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 1:47 [PATCH net-next v2 0/5] gve: Add flow steering support Ziwei Xiao
2024-06-13 1:47 ` [PATCH net-next v2 1/5] gve: Add adminq mutex lock Ziwei Xiao
2024-06-13 1:47 ` [PATCH net-next v2 2/5] gve: Add adminq extended command Ziwei Xiao
2024-06-13 1:47 ` [PATCH net-next v2 3/5] gve: Add flow steering device option Ziwei Xiao
2024-06-15 2:22 ` Jakub Kicinski [this message]
2024-06-13 1:47 ` [PATCH net-next v2 4/5] gve: Add flow steering adminq commands Ziwei Xiao
2024-06-13 1:47 ` [PATCH net-next v2 5/5] gve: Add flow steering ethtool support Ziwei Xiao
2024-06-15 2:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240614192209.7c69df0b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.