From: Simon Horman <horms@kernel.org>
To: Petr Oros <poros@redhat.com>
Cc: ivecera@redhat.com, netdev@vger.kernel.org,
Marcin Domagala <marcinx.domagala@intel.com>,
Konrad Knitter <konrad.knitter@intel.com>,
Eric Dumazet <edumazet@google.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
przemyslaw.kitszel@intel.com, Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: use proper macro for testing bit
Date: Sat, 15 Jun 2024 16:16:41 +0100 [thread overview]
Message-ID: <20240615151641.GG8447@kernel.org> (raw)
In-Reply-To: <20240614094338.467052-1-poros@redhat.com>
On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.
Hi Petr,
it might be nice to include a brief explanation as to
why test_bit() is correct.
>
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@redhat.com>
> Acked-by: Ivan Vecera <ivecera@redhat.com>
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Petr Oros <poros@redhat.com>
Cc: netdev@vger.kernel.org, ivecera@redhat.com,
przemyslaw.kitszel@intel.com,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Konrad Knitter <konrad.knitter@intel.com>,
Marcin Domagala <marcinx.domagala@intel.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2] ice: use proper macro for testing bit
Date: Sat, 15 Jun 2024 16:16:41 +0100 [thread overview]
Message-ID: <20240615151641.GG8447@kernel.org> (raw)
In-Reply-To: <20240614094338.467052-1-poros@redhat.com>
On Fri, Jun 14, 2024 at 11:43:38AM +0200, Petr Oros wrote:
> Do not use _test_bit() macro for testing bit. The proper macro for this
> is one without underline.
Hi Petr,
it might be nice to include a brief explanation as to
why test_bit() is correct.
>
> Fixes: 4da71a77fc3b ("ice: read internal temperature sensor")
> Signed-off-by: Petr Oros <poros@redhat.com>
> Acked-by: Ivan Vecera <ivecera@redhat.com>
...
next prev parent reply other threads:[~2024-06-15 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 9:43 [Intel-wired-lan] [PATCH net v2] ice: use proper macro for testing bit Petr Oros
2024-06-14 9:43 ` Petr Oros
2024-06-15 15:16 ` Simon Horman [this message]
2024-06-15 15:16 ` Simon Horman
2024-06-17 12:58 ` [Intel-wired-lan] " Alexander Lobakin
2024-06-17 12:58 ` Alexander Lobakin
2024-06-17 19:04 ` [Intel-wired-lan] " Simon Horman
2024-06-17 19:04 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240615151641.GG8447@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=ivecera@redhat.com \
--cc=konrad.knitter@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.szycik@linux.intel.com \
--cc=marcinx.domagala@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.