From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A298BC27C53 for ; Sun, 16 Jun 2024 22:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xBfMSfyjgbY7FZecRWp+DlDLTY0tm+CsG9NAsQ2uovA=; b=13MIGhp06cAcDb fdTD/6Pu+2FmcF0AqVpd59IzmW5GAOVCYipd+ws1SkdKvjNh3J3RqyXctmHU/13vtxNCEuJ/pfI+u C+SD1Cu6B3Sbwxb5XxjCGJPatWkydL8DSzmrAIrCneUpkMC9e7VD0tQjN12OnWMIPQJsseDv5o05K 6sTpZt0JwtYPRyKWpn/daYnrTa4gl/FCbfXpnKkZOmCRIVEL22aYIKi++IfO/eb6szhiKHUt8FfXG 5tioxfaoYcl2pz/Lm2bDgAfKjtMz9BGphtDKUNI9cDWvGvygZrn6ZyYZF6xnqEwoh3q6RgGV4IaKf ZWZkQPOVVLN0eV2WXcMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIyki-00000008TaU-2wJ1; Sun, 16 Jun 2024 22:53:36 +0000 Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sIykf-00000008Ta2-3ReW for linux-riscv@lists.infradead.org; Sun, 16 Jun 2024 22:53:35 +0000 Date: Sun, 16 Jun 2024 22:53:14 +0000 From: Yixun Lan To: Yangyu Chen Cc: linux-riscv@lists.infradead.org, Conor Dooley , Palmer Dabbelt , Paul Walmsley , Samuel Holland , Anup Patel , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device tree Message-ID: <20240616225314.GA3988639@ofsar> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240616_155333_913124_BF911021 X-CRM114-Status: UNSURE ( 6.23 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 01:20 Mon 17 Jun , Yangyu Chen wrote: > Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1]. > .. snip > + uart0: serial@d4017000 { > + compatible = "intel,xscale-uart"; are you sure the uart IP is fully compatible with xscale? otherwise I'd suggest to introduce a vendor specific one.. > + reg = <0x0 0xd4017000 0x0 0x100>; > + interrupts = <42>; > + clock-frequency = <14000000>; > + reg-shift = <2>; > + reg-io-width = <4>; > + status = "disabled"; > + }; > + }; > +}; it's better to also add other uart nodes, I feel it's more complete -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50DB14D13F; Sun, 16 Jun 2024 22:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718578414; cv=none; b=TCmSB++4tKdXbtlGdGYzVR5V99V/FWwV7T96nBYouQoExdUTnmuUEGbfmAhW5yqPzx41m7n/oxDfQi7D080KjXgwvzdLccixNMMuR1MQW84Xcy+NLSUUCmymGi5HewDY5cZL1WXpI1TtkENBS7NzWhXuKVP18288nhU58XZZn/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718578414; c=relaxed/simple; bh=EHAngz4Pb351ADPg/GJDmja1Ezjv0UDBmrqAOfjKEfA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BeZARYFGFOktmz6Y9hYYBSmuv5zjlKr+zVyVox40jAPCtEcPtKq1gxwpzSIBrVlh4Q3/Sps7Y+xyYr3z9az6I3Efe+Cinue6BOErkd6XnCyfIS99NSdyCxTw/YvEaz3o3oib+8sSU8nAnlhVF5TBeESFF1GCc16/AZrzkUuJmCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Date: Sun, 16 Jun 2024 22:53:14 +0000 From: Yixun Lan To: Yangyu Chen Cc: linux-riscv@lists.infradead.org, Conor Dooley , Palmer Dabbelt , Paul Walmsley , Samuel Holland , Anup Patel , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 7/9] riscv: dts: add initial SpacemiT K1 SoC device tree Message-ID: <20240616225314.GA3988639@ofsar> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 01:20 Mon 17 Jun , Yangyu Chen wrote: > Banana Pi BPI-F3 motherboard is powered by SpacemiT K1[1]. > .. snip > + uart0: serial@d4017000 { > + compatible = "intel,xscale-uart"; are you sure the uart IP is fully compatible with xscale? otherwise I'd suggest to introduce a vendor specific one.. > + reg = <0x0 0xd4017000 0x0 0x100>; > + interrupts = <42>; > + clock-frequency = <14000000>; > + reg-shift = <2>; > + reg-io-width = <4>; > + status = "disabled"; > + }; > + }; > +}; it's better to also add other uart nodes, I feel it's more complete -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55