From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: daniel.sneddon@linux.intel.com, tony.luck@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-perf-users@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH PATCH 3/9] perf/x86/intel: Use topology_cpu_type() to get cpu-type
Date: Mon, 17 Jun 2024 02:11:38 -0700 [thread overview]
Message-ID: <20240617-add-cpu-type-v1-3-b88998c01e76@linux.intel.com> (raw)
In-Reply-To: <20240617-add-cpu-type-v1-0-b88998c01e76@linux.intel.com>
find_hybrid_pmu_for_cpu() uses get_this_hybrid_cpu_type() to get the CPU
type, but it returns an invalid cpu-type when X86_FEATURE_HYBRID_CPU is not
set. Some hybrid variants do enumerate cpu-type regardless of
X86_FEATURE_HYBRID_CPU.
Replace get_this_hybrid_cpu_type() with topology_cpu_type() to get cpu-type
irrespective of hybrid status. Moreover, get_this_hybrid_cpu_type()
executes the CPUID instruction to get the cpu-type, which is slower than
using the per-cpu value.
Signed-off-by: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
---
arch/x86/events/intel/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index 38c1b1f1deaa..8067a735705a 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -4753,7 +4753,7 @@ static void intel_pmu_check_hybrid_pmus(struct x86_hybrid_pmu *pmu)
static struct x86_hybrid_pmu *find_hybrid_pmu_for_cpu(void)
{
- u8 cpu_type = get_this_hybrid_cpu_type();
+ u8 cpu_type = topology_cpu_type(smp_processor_id());
int i;
/*
--
2.34.1
next prev parent reply other threads:[~2024-06-17 9:11 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 9:11 [PATCH 0/9] Add CPU-type to topology Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 1/9] x86/cpu/topology: Add x86_cpu_type to struct cpuinfo_topology Pawan Gupta
2024-06-17 9:35 ` Andrew Cooper
2024-06-17 17:51 ` Pawan Gupta
2024-06-17 13:24 ` kernel test robot
2024-06-17 13:45 ` kernel test robot
2024-06-18 21:28 ` Borislav Petkov
2024-06-19 3:31 ` Pawan Gupta
2024-06-20 15:51 ` Borislav Petkov
2024-06-21 6:36 ` Pawan Gupta
2024-06-18 21:33 ` Mario Limonciello
2024-06-18 22:03 ` Dave Hansen
2024-06-17 9:11 ` [PATCH PATCH 2/9] cpufreq: intel_pstate: Use topology_cpu_type() to get cpu-type Pawan Gupta
2024-06-17 9:27 ` srinivas pandruvada
2024-06-17 18:36 ` Pawan Gupta
2024-06-17 14:01 ` kernel test robot
2024-06-17 9:11 ` Pawan Gupta [this message]
2024-06-17 14:50 ` [PATCH PATCH 3/9] perf/x86/intel: " Dave Hansen
2024-06-17 18:09 ` Pawan Gupta
2024-06-17 18:17 ` Dave Hansen
2024-06-17 18:25 ` Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 4/9] x86/cpu: Remove get_this_hybrid_cpu_type() Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 5/9] x86/cpu: Name CPU matching macro more generically (and shorten) Pawan Gupta
2024-06-17 9:11 ` [PATCH PATCH 6/9] x86/cpu: Add cpu_type to struct x86_cpu_id Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 7/9] x86/cpu: Update x86_match_cpu() to also use cpu-type Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 8/9] x86/bugs: Declutter vulnerable CPU list Pawan Gupta
2024-06-17 9:38 ` Andrew Cooper
2024-06-17 18:13 ` Pawan Gupta
2024-06-17 14:13 ` Dave Hansen
2024-06-17 18:14 ` Pawan Gupta
2024-06-17 23:52 ` Pawan Gupta
2024-06-18 0:08 ` Luck, Tony
2024-06-18 3:19 ` Pawan Gupta
2024-06-17 9:12 ` [PATCH PATCH 9/9] x86/rfds: Exclude P-only parts from the RFDS affected list Pawan Gupta
2024-06-17 9:43 ` Andrew Cooper
2024-06-17 14:34 ` Dave Hansen
2024-06-17 18:19 ` Pawan Gupta
2024-06-17 14:33 ` Dave Hansen
2024-06-17 18:24 ` Pawan Gupta
2024-06-18 12:49 ` [PATCH 0/9] Add CPU-type to topology Brice Goglin
2024-06-19 1:53 ` Pawan Gupta
2024-06-19 10:34 ` srinivas pandruvada
2024-06-19 21:25 ` Brice Goglin
2024-06-20 15:06 ` Dave Hansen
2024-06-20 15:22 ` Brice Goglin
2024-06-21 6:23 ` Pawan Gupta
2024-06-27 12:55 ` Ricardo Neri
2024-06-27 12:51 ` Ricardo Neri
2024-06-27 13:22 ` Pawan Gupta
2024-06-27 15:26 ` Ricardo Neri
2024-06-27 16:54 ` Liang, Kan
2024-06-29 11:37 ` Brice Goglin
2024-06-27 12:53 ` Ricardo Neri
2024-06-19 21:22 ` Brice Goglin
2024-06-27 15:22 ` Ricardo Neri
2024-06-27 15:22 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617-add-cpu-type-v1-3-b88998c01e76@linux.intel.com \
--to=pawan.kumar.gupta@linux.intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.