From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <djwong@kernel.org>,
chandanbabu@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] xfs: don't treat append-only files as having preallocations
Date: Mon, 17 Jun 2024 08:46:03 +0200 [thread overview]
Message-ID: <20240617064603.GA18484@lst.de> (raw)
In-Reply-To: <Zm/DoN5npLCd+Y/n@dread.disaster.area>
On Mon, Jun 17, 2024 at 03:03:28PM +1000, Dave Chinner wrote:
> > That case should be covered by the XFS_IDIRTY_RELEASE, at least
> > except for O_SYNC workloads.
>
> Ah, so I fixed the problem independently 7 or 8 years later to fix
> Linux NFS server performance issues. Ok, that makes removing the
> flag less bad, but I still don't see the harm in keeping it there
> given that behaviour has existed for the past 20 years....
I'm really kinda worried about these unaccounted preallocations lingering
around basically forever. Note that in current mainline there actually
is a path removing them more or less accidentally when there are
delalloc blocks in a can_free_eofblocks path with force == true,
but that's going away with the next patch.
next prev parent reply other threads:[~2024-06-17 6:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 17:46 [PATCHSET] xfs: random fixes for 6.10 Darrick J. Wong
2024-06-12 17:46 ` [PATCH 1/5] xfs: don't treat append-only files as having preallocations Darrick J. Wong
2024-06-13 6:03 ` Dave Chinner
2024-06-13 8:28 ` Christoph Hellwig
2024-06-17 5:03 ` Dave Chinner
2024-06-17 6:46 ` Christoph Hellwig [this message]
2024-06-17 23:28 ` Dave Chinner
2024-06-12 17:47 ` [PATCH 2/5] xfs: fix freeing speculative preallocations for preallocated files Darrick J. Wong
2024-06-12 17:47 ` [PATCH 3/5] xfs: restrict when we try to align cow fork delalloc to cowextsz hints Darrick J. Wong
2024-06-13 5:06 ` Christoph Hellwig
2024-06-14 4:13 ` Darrick J. Wong
2024-06-14 4:41 ` Christoph Hellwig
2024-06-14 5:27 ` Darrick J. Wong
2024-06-14 5:30 ` Christoph Hellwig
2024-06-12 17:47 ` [PATCH 4/5] xfs: allow unlinked symlinks and dirs with zero size Darrick J. Wong
2024-06-13 4:57 ` Christoph Hellwig
2024-06-12 17:47 ` [PATCH 5/5] xfs: verify buffer, inode, and dquot items every tx commit Darrick J. Wong
2024-06-13 5:07 ` Christoph Hellwig
2024-06-13 7:04 ` Dave Chinner
2024-06-14 3:49 ` Darrick J. Wong
2024-06-14 4:42 ` Christoph Hellwig
2024-06-14 5:23 ` Darrick J. Wong
2024-06-18 0:18 ` [PATCH v1.1 " Darrick J. Wong
2024-06-18 6:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617064603.GA18484@lst.de \
--to=hch@lst.de \
--cc=chandanbabu@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.