From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>, Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 1/3] nvmet: do not return 'reserved' for empty TSAS values
Date: Mon, 17 Jun 2024 09:27:26 +0200 [thread overview]
Message-ID: <20240617072728.134728-2-hare@kernel.org> (raw)
In-Reply-To: <20240617072728.134728-1-hare@kernel.org>
The 'TSAS' value is only defined for TCP and RDMA, but returning
'reserved' for undefined values tricked nvmetcli to try to write
'reserved' when restoring from a config file. This caused an error
and the configuration would not be applied.
Fixes: 3f123494db72 ("nvmet: make TCP sectype settable via configfs")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/nvme/target/configfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index bd87dfd173a4..e60224356048 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -410,7 +410,7 @@ static ssize_t nvmet_addr_tsas_show(struct config_item *item,
return sprintf(page, "%s\n", nvmet_addr_tsas_rdma[i].name);
}
}
- return sprintf(page, "reserved\n");
+ return sprintf(page, "\n");
}
static ssize_t nvmet_addr_tsas_store(struct config_item *item,
--
2.35.3
next prev parent reply other threads:[~2024-06-17 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 7:27 [PATCH 0/3] nvmet: fixup nvmetcli save/restore Hannes Reinecke
2024-06-17 7:27 ` Hannes Reinecke [this message]
2024-06-17 18:29 ` [PATCH 1/3] nvmet: do not return 'reserved' for empty TSAS values Keith Busch
2024-06-17 7:27 ` [PATCH 2/3] nvme: fixup comment for nvme RDMA Provider Type Hannes Reinecke
2024-06-18 6:45 ` Christoph Hellwig
2024-06-17 7:27 ` [PATCH 3/3] nvmet: make 'tsas' attribute idempotent for RDMA Hannes Reinecke
2024-06-18 6:46 ` Christoph Hellwig
2024-06-21 16:01 ` [PATCH 0/3] nvmet: fixup nvmetcli save/restore Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617072728.134728-2-hare@kernel.org \
--to=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.