From: "Marek Behún" <kabel@kernel.org>
To: "Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>, "Arnd Bergmann" <arnd@arndb.de>,
soc@kernel.org, arm@kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Marek Behún" <kabel@kernel.org>
Subject: [PATCH v3 05/17] firmware: turris-mox-rwtm: Use the boolean type where appropriate
Date: Mon, 17 Jun 2024 16:45:20 +0200 [thread overview]
Message-ID: <20240617144532.17385-6-kabel@kernel.org> (raw)
In-Reply-To: <20240617144532.17385-1-kabel@kernel.org>
Use the boolean type for has_board_info, has_pubkey and last_sig_done
members of the driver's private structure.
Signed-off-by: Marek Behún <kabel@kernel.org>
---
drivers/firmware/turris-mox-rwtm.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
index f7f9859b8f61..5ed480ac5146 100644
--- a/drivers/firmware/turris-mox-rwtm.c
+++ b/drivers/firmware/turris-mox-rwtm.c
@@ -19,6 +19,7 @@
#include <linux/platform_device.h>
#include <linux/sizes.h>
#include <linux/slab.h>
+#include <linux/types.h>
#define DRIVER_NAME "turris-mox-rwtm"
@@ -67,13 +68,13 @@ struct mox_rwtm {
struct completion cmd_done;
/* board information */
- int has_board_info;
+ bool has_board_info;
u64 serial_number;
int board_version, ram_size;
u8 mac_address1[ETH_ALEN], mac_address2[ETH_ALEN];
/* public key burned in eFuse */
- int has_pubkey;
+ bool has_pubkey;
u8 pubkey[135];
#ifdef CONFIG_DEBUG_FS
@@ -85,7 +86,7 @@ struct mox_rwtm {
*/
struct dentry *debugfs_root;
u32 last_sig[34];
- int last_sig_done;
+ bool last_sig_done;
#endif
};
@@ -229,7 +230,7 @@ static int mox_get_board_info(struct mox_rwtm *rwtm)
reply->status[5]);
reply_to_mac_addr(rwtm->mac_address2, reply->status[6],
reply->status[7]);
- rwtm->has_board_info = 1;
+ rwtm->has_board_info = true;
pr_info("Turris Mox serial number %016llX\n",
rwtm->serial_number);
@@ -256,7 +257,7 @@ static int mox_get_board_info(struct mox_rwtm *rwtm)
} else {
u32 *s = reply->status;
- rwtm->has_pubkey = 1;
+ rwtm->has_pubkey = true;
sprintf(rwtm->pubkey,
"%06x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x%08x",
ret, s[0], s[1], s[2], s[3], s[4], s[5], s[6], s[7],
@@ -352,7 +353,7 @@ static ssize_t do_sign_read(struct file *file, char __user *buf, size_t len,
/* 2 arrays of 17 32-bit words are 136 bytes */
ret = simple_read_from_buffer(buf, len, ppos, rwtm->last_sig, 136);
- rwtm->last_sig_done = 0;
+ rwtm->last_sig_done = false;
return ret;
}
@@ -418,7 +419,7 @@ static ssize_t do_sign_write(struct file *file, const char __user *buf,
*/
memcpy(rwtm->last_sig, rwtm->buf + 68, 136);
cpu_to_be32_array(rwtm->last_sig, rwtm->last_sig, 34);
- rwtm->last_sig_done = 1;
+ rwtm->last_sig_done = true;
mutex_unlock(&rwtm->busy);
return len;
--
2.44.2
next prev parent reply other threads:[~2024-06-17 14:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 14:45 [PATCH v3 00/17] Updates for turris-mox-rwtm driver Marek Behún
2024-06-17 14:45 ` [PATCH v3 01/17] firmware: turris-mox-rwtm: Do not complete if there are no waiters Marek Behún
2024-06-17 19:42 ` Andy Shevchenko
2024-06-17 14:45 ` [PATCH v3 02/17] firmware: turris-mox-rwtm: Fix checking return value of wait_for_completion_timeout() Marek Behún
2024-06-17 14:45 ` [PATCH v3 03/17] firmware: turris-mox-rwtm: Use macro constant instead of hardcoded 4096 Marek Behún
2024-06-17 14:45 ` [PATCH v3 04/17] firmware: turris-mox-rwtm: Use ETH_ALEN instead of hardcoded 6 Marek Behún
2024-06-17 14:45 ` Marek Behún [this message]
2024-06-17 19:46 ` [PATCH v3 05/17] firmware: turris-mox-rwtm: Use the boolean type where appropriate Andy Shevchenko
2024-06-17 14:45 ` [PATCH v3 06/17] firmware: turris-mox-rwtm: Hide signature related constants behind macros Marek Behún
2024-06-17 19:52 ` Andy Shevchenko
2024-06-17 14:45 ` [PATCH v3 07/17] firmware: turris-mox-rwtm: Fix driver includes Marek Behún
2024-06-17 14:45 ` [PATCH v3 08/17] firmware: turris-mox-rwtm: Don't create own kobject type Marek Behún
2024-06-17 19:57 ` Andy Shevchenko
2024-06-17 14:45 ` [PATCH v3 09/17] firmware: turris-mox-rwtm: Simplify debugfs code Marek Behún
2024-06-17 20:22 ` Andy Shevchenko
2024-07-12 13:16 ` Marek Behún
2024-06-17 14:45 ` [PATCH v3 10/17] firmware: turris-mox-rwtm: Convert rest to devm_* and get rid of driver .remove() Marek Behún
2024-06-17 14:45 ` [PATCH v3 11/17] firmware: turris-mox-rwtm: Use dev_err_probe() where possible Marek Behún
2024-06-17 14:45 ` [PATCH v3 12/17] firmware: turris-mox-rwtm: Initialize completion before mailbox Marek Behún
2024-06-17 14:45 ` [PATCH v3 13/17] firmware: turris-mox-rwtm: Drop redundant device pointer Marek Behún
2024-06-17 14:45 ` [PATCH v3 14/17] firmware: turris-mox-rwtm: Use devm_mutex_init() instead of mutex_init() Marek Behún
2024-06-17 14:45 ` [PATCH v3 15/17] firmware: turris-mox-rwtm: Use container_of() instead of hwrng .priv member Marek Behún
2024-06-17 20:27 ` Andy Shevchenko
2024-06-17 14:45 ` [PATCH v3 16/17] firmware: turris-mox-rwtm: Use EOPNOTSUPP instead of ENOSYS Marek Behún
2024-06-17 14:45 ` [PATCH v3 17/17] firmware: turris-mox-rwtm: Deduplicate command execution code Marek Behún
2024-06-17 20:29 ` Andy Shevchenko
2024-06-17 20:31 ` [PATCH v3 00/17] Updates for turris-mox-rwtm driver Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617144532.17385-6-kabel@kernel.org \
--to=kabel@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@kernel.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.