From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E2C0C27C79 for ; Mon, 17 Jun 2024 14:52:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2B47E40319; Mon, 17 Jun 2024 14:52:51 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id lbS3bJbiw84J; Mon, 17 Jun 2024 14:52:50 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 527BB408C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1718635970; bh=SP8NAzf/ehsG5R5+sT6BRAtIR1rF7U+ThkfJOLDlBJM=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=MDeq14c6jUvUT25t+nAl+JNSV7BUcMNct/Qf/XSgeUzM0Oadv6sMIMVSLYtwD2LSC E7k4ohHcpXGQuLZlWJVB2lv1tckb2qqAJv6Nxxu2P7AoHZWBo2E+S0m+W+zZakrTmy oR7DGWIOQ4EGe9zgkhUqin8EZllu4t/tyJTq4UPoeuPDb1pr90QRRdzVcvpdqmHy/a 3C4VytEMF/sBiqBABIVYZkpETAHT/UM3eP8OOuiiekn12fJEMs5E0YqEyLKG342Phe awtyjsqlMtCo9TML0VhoKXRrOl9Lt+FqLE2a4DvtAcHxuUSsO0W4w9xlGowYNGrBlN amBK964Gx1IfA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 527BB408C5; Mon, 17 Jun 2024 14:52:50 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 105781BF377 for ; Mon, 17 Jun 2024 14:52:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F037040319 for ; Mon, 17 Jun 2024 14:52:48 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Q1NVX7X_awNl for ; Mon, 17 Jun 2024 14:52:48 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 2130D401D8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2130D401D8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 2130D401D8 for ; Mon, 17 Jun 2024 14:52:47 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3EF5E611A6; Mon, 17 Jun 2024 14:52:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18967C2BD10; Mon, 17 Jun 2024 14:52:44 +0000 (UTC) Date: Mon, 17 Jun 2024 15:52:42 +0100 From: Simon Horman To: Jakub Kicinski Message-ID: <20240617145242.GV8447@kernel.org> References: <20240614125935.900102-1-anil.samal@intel.com> <20240614125935.900102-4-anil.samal@intel.com> <20240614175559.4826e4aa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614175559.4826e4aa@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718635966; bh=MG9R0YfcKoDfDsSnG7bCZrb8TdRezjqK3o93Y26S1tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CdnI448E7dlOEMvXHIL43p3SKF1g+6khI9sOn99rKqrjgzzTr45BhRTDk05D/GZBi gJYL+H9T58CvtvKH75QvWBrVvzgfs0xGb/zsphaDAzSjBO+HXbXziFqzUN7FT9wYfc uAHPIA+RMUWx6pJ/7OS9XTdWnfBsqe73kGeI4T5wLfWHxqU59gB8TP1xMh+rmZvdPi fqpryfnXl7jHdGGfobSdybZFUNo3Hl17G+CGQqFpE6tVsC8AkrRDW/jbvfPU09YpC2 uvGAN63FOua4xp0MJr4pi94TxXYYNUQ9vIXXaSnyjqe3BYDtFK/v5mZGkJZjvMtEQq 0GkXvTkOKxEeQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=CdnI448E Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, lukasz.czapnik@intel.com, Anil Samal , leszek.pepiak@intel.com, intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jun 14, 2024 at 05:55:59PM -0700, Jakub Kicinski wrote: > On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > > To debug link issues in the field, serdes Tx/Rx equalizer values > > help to determine the health of serdes lane. > > > > Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. > > The following list of equalizer param is supported > > a. rx_equalization_pre2 > > b. rx_equalization_pre1 > > c. rx_equalization_post1 > > d. rx_equalization_bflf > > e. rx_equalization_bfhf > > f. rx_equalization_drate > > g. tx_equalization_pre1 > > h. tx_equalization_pre3 > > i. tx_equalization_atten > > j. tx_equalization_post1 > > k. tx_equalization_pre2 > > I'd be tempted to create a dedicated way to dump vendor specific signal > quality indicators (both for Ethernet and PCIe). Feels little cleaner > than appending to a flat mixed-purpose dump. But either way is fine by > me, TBH. Much better than vendor tools poking into the BAR... +1 In particular, I agree that either way ethtool -d is better than than vendor tools poking into the BAR. Because the Kernel can mediate access to the hardware and see the data. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 631B91D9504 for ; Mon, 17 Jun 2024 14:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635967; cv=none; b=eMwTDwsK7GFt+Vkg5fJ4miB0aqzbIj9WP4/pD0ic6+6RAGMg4PmJqvTwG7LxJW+a/HZc46KymDDkyQg7HxRTXkQJrvu5xDE5sqiBlojQCNjwsTaqY0MTq3EBL8MM3O76ZHMGpvC+Ow4XYUR/wvez9FbKbfb9k3ITb+MlZJWhZ7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718635967; c=relaxed/simple; bh=MG9R0YfcKoDfDsSnG7bCZrb8TdRezjqK3o93Y26S1tw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I3L2mTgcjxxu8RG3wtqwX54LiZndYT+TjFQ+qxzfspbxVe6SvhtTlPzN1/uOYV/PFguXQgMZwQ6RtbGQJRK2QF2HMjDn0qaq+43YCfo4PlK3vBu3+5GyxWHwUst1gpZByujQWnKeHbCemTqtoZWdgEBXSrr0rfyK2k6uIP3hSGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CdnI448E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CdnI448E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18967C2BD10; Mon, 17 Jun 2024 14:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718635966; bh=MG9R0YfcKoDfDsSnG7bCZrb8TdRezjqK3o93Y26S1tw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CdnI448E7dlOEMvXHIL43p3SKF1g+6khI9sOn99rKqrjgzzTr45BhRTDk05D/GZBi gJYL+H9T58CvtvKH75QvWBrVvzgfs0xGb/zsphaDAzSjBO+HXbXziFqzUN7FT9wYfc uAHPIA+RMUWx6pJ/7OS9XTdWnfBsqe73kGeI4T5wLfWHxqU59gB8TP1xMh+rmZvdPi fqpryfnXl7jHdGGfobSdybZFUNo3Hl17G+CGQqFpE6tVsC8AkrRDW/jbvfPU09YpC2 uvGAN63FOua4xp0MJr4pi94TxXYYNUQ9vIXXaSnyjqe3BYDtFK/v5mZGkJZjvMtEQq 0GkXvTkOKxEeQ== Date: Mon, 17 Jun 2024 15:52:42 +0100 From: Simon Horman To: Jakub Kicinski Cc: Anil Samal , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, leszek.pepiak@intel.com, przemyslaw.kitszel@intel.com, lukasz.czapnik@intel.com, anthony.l.nguyen@intel.com, Jesse Brandeburg Subject: Re: [PATCH iwl-next v3 3/3] ice: Implement driver functionality to dump serdes equalizer values Message-ID: <20240617145242.GV8447@kernel.org> References: <20240614125935.900102-1-anil.samal@intel.com> <20240614125935.900102-4-anil.samal@intel.com> <20240614175559.4826e4aa@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240614175559.4826e4aa@kernel.org> On Fri, Jun 14, 2024 at 05:55:59PM -0700, Jakub Kicinski wrote: > On Fri, 14 Jun 2024 05:58:17 -0700 Anil Samal wrote: > > To debug link issues in the field, serdes Tx/Rx equalizer values > > help to determine the health of serdes lane. > > > > Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer. > > The following list of equalizer param is supported > > a. rx_equalization_pre2 > > b. rx_equalization_pre1 > > c. rx_equalization_post1 > > d. rx_equalization_bflf > > e. rx_equalization_bfhf > > f. rx_equalization_drate > > g. tx_equalization_pre1 > > h. tx_equalization_pre3 > > i. tx_equalization_atten > > j. tx_equalization_post1 > > k. tx_equalization_pre2 > > I'd be tempted to create a dedicated way to dump vendor specific signal > quality indicators (both for Ethernet and PCIe). Feels little cleaner > than appending to a flat mixed-purpose dump. But either way is fine by > me, TBH. Much better than vendor tools poking into the BAR... +1 In particular, I agree that either way ethtool -d is better than than vendor tools poking into the BAR. Because the Kernel can mediate access to the hardware and see the data.