From: Simon Horman <horms@kernel.org>
To: "Kamil Horák - 2N" <kamilh@axis.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/4] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes
Date: Mon, 17 Jun 2024 16:17:13 +0100 [thread overview]
Message-ID: <20240617151713.GW8447@kernel.org> (raw)
In-Reply-To: <20240617113841.3694934-5-kamilh@axis.com>
On Mon, Jun 17, 2024 at 01:38:41PM +0200, Kamil Horák - 2N wrote:
> Implement single-pair BroadR-Reach modes on bcm5481x PHY by Broadcom.
> Create set of functions alternative to IEEE 802.3 to handle configuration
> of these modes on compatible Broadcom PHYs.
>
> Signed-off-by: Kamil Horák - 2N <kamilh@axis.com>
...
> +/**
> + * lre_update_link - update link status in @phydev
> + * @phydev: target phy_device struct
> + *
> + * Description: Update the value in phydev->link to reflect the
> + * current link value. In order to do this, we need to read
> + * the status register twice, keeping the second value.
> + * This is a genphy_update_link modified to work on LRE registers
> + * of BroadR-Reach PHY
> + */
Hi Kamil,
A minor nit from my side:
Please consider adding a "Returns:" section to this kernel doc.
Doing so as a follow-up would be fine IMHO.
Flagged by kernel-doc -none -Wall
> +static int lre_update_link(struct phy_device *phydev)
...
next prev parent reply other threads:[~2024-06-17 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 11:38 [PATCH v7 0/4] net: phy: bcm5481x: add support for BroadR-Reach mode Kamil Horák - 2N
2024-06-17 11:38 ` [PATCH v7 1/4] net: phy: bcm54811: New link mode for BroadR-Reach Kamil Horák - 2N
2024-06-19 10:35 ` Florian Fainelli
2024-06-17 11:38 ` [PATCH v7 2/4] net: phy: bcm54811: Add LRE registers definitions Kamil Horák - 2N
2024-06-19 10:36 ` Florian Fainelli
2024-06-17 11:38 ` [PATCH v7 3/4] dt-bindings: ethernet-phy: add optional brr-mode flag Kamil Horák - 2N
2024-06-17 16:25 ` Conor Dooley
2024-06-19 10:37 ` Florian Fainelli
2024-06-17 11:38 ` [PATCH v7 4/4] net: phy: bcm-phy-lib: Implement BroadR-Reach link modes Kamil Horák - 2N
2024-06-17 15:17 ` Simon Horman [this message]
2024-06-19 1:05 ` Jakub Kicinski
2024-06-19 6:44 ` Ratheesh Kannoth
2024-06-19 10:34 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617151713.GW8447@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kamilh@axis.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.