Re: [PATCH v1 1/4] board: asus: transformer: add ASUS Transformer T20 family support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

On Sat, Jun 15, 2024 at 12:19:43PM +0300, Svyatoslav Ryhel wrote:

> The Asus Eee Pad Transformer family are 2-in-1 detachable/slider
> tablets developed by Asus that run the Android operating system.
> The Eee Pad Transformers feature a 10.1-inch (260 mm) display,
> an Nvidia Tegra 2 dual-core chip, 1 GB of RAM, and 16/32 GB of storage.
> Transformers board derives from Nvidia Ventana development board.
> 
> This patch brings support for all 3 known T20 Transformers:
> - Asus Eee Pad Transformer TF101
> - Asus Eee Pad Transformer TF101G
> - Asus Eee Pad Slider SL101
> 
> Tested-by: Robert Eckelmann <longnoserob@gmail.com> # ASUS TF101
> Tested-by: Antoni Aloy Torrens <aaloytorrens@gmail.com> # ASUS TF101
> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
[snip]
> diff --git a/include/configs/transformer-t20.h b/include/configs/transformer-t20.h
> new file mode 100644
> index 0000000000..45f937804f
> --- /dev/null
> +++ b/include/configs/transformer-t20.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + *  (C) Copyright 2010,2011
> + *  NVIDIA Corporation <www.nvidia.com>
> + *
> + *  (C) Copyright 2022
> + *  Svyatoslav Ryhel <clamor95@gmail.com>
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#include <linux/sizes.h>
> +
> +#include "tegra20-common.h"
> +#include "transformer-common.h"
> +
> +/* Board-specific serial config */
> +#define CFG_SYS_NS16550_COM1		NV_PA_APB_UARTD_BASE
> +
> +#include "tegra-common-post.h"
> +
> +#endif /* __CONFIG_H */

Ugh, what one of these includes is the one that requires us to have
<linux/sizes.h> in it? It's not a problem you're introducing, but it'd
be good to clean it up.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]