From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Radu Pirea <radu-nicolae.pirea@oss.nxp.com>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next v15 02/14] net: Move dev_set_hwtstamp_phylib to net/core/dev.h
Date: Mon, 17 Jun 2024 18:26:41 -0700 [thread overview]
Message-ID: <20240617182641.7fa3921e@kernel.org> (raw)
In-Reply-To: <20240612-feature_ptp_netnext-v15-2-b2a086257b63@bootlin.com>
On Wed, 12 Jun 2024 17:04:02 +0200 Kory Maincent wrote:
> This declaration was added to the header to be called from ethtool.
> ethtool is separated from core for code organization but it is not really
> a separate entity, it controls very core things.
> As ethtool is an internal stuff it is not wise to have it in netdevice.h.
> Move the declaration to net/core/dev.h instead.
>
> Remove the EXPORT_SYMBOL_GPL call as ethtool can not be built as a module.
>
> Reviewed-by: Willem de Bruijn <willemb@google.com>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
I'll take this one, it stands on its own.
next prev parent reply other threads:[~2024-06-18 1:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 15:04 [PATCH net-next v15 00/14] net: Make timestamping selectable Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 01/14] net_tstamp: Add TIMESTAMPING SOFTWARE and HARDWARE mask Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 02/14] net: Move dev_set_hwtstamp_phylib to net/core/dev.h Kory Maincent
2024-06-18 1:26 ` Jakub Kicinski [this message]
2024-06-12 15:04 ` [PATCH net-next v15 03/14] net: Make dev_get_hwtstamp_phylib accessible Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 04/14] net: Make net_hwtstamp_validate accessible Kory Maincent
2024-06-18 1:26 ` Jakub Kicinski
2024-06-12 15:04 ` [PATCH net-next v15 05/14] net: Change the API of PHY default timestamp to MAC Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 06/14] net: net_tstamp: Add unspec field to hwtstamp_source enumeration Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 07/14] net: Add struct kernel_ethtool_ts_info Kory Maincent
2024-06-14 14:02 ` Paolo Abeni
2024-06-14 17:46 ` Russell King (Oracle)
2024-06-12 15:04 ` [PATCH net-next v15 08/14] ptp: Add phc source and helpers to register specific PTP clock or get information Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 09/14] net: Add the possibility to support a selected hwtstamp in netdevice Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 10/14] net: netdevsim: ptp_mock: Convert to netdev_ptp_clock_register Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 11/14] net: macb: " Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 12/14] net: ptp: Move ptp_clock_index() to builtin symbol Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 13/14] net: ethtool: tsinfo: Add support for hwtstamp provider and get/set hwtstamp config Kory Maincent
2024-06-18 1:43 ` Jakub Kicinski
2024-06-21 8:54 ` Kory Maincent
2024-06-21 15:56 ` Jakub Kicinski
2024-06-21 16:25 ` Kory Maincent
2024-06-12 15:04 ` [PATCH net-next v15 14/14] netlink: specs: tsinfo: Enhance netlink attributes and add a set command Kory Maincent
2024-06-18 1:50 ` [PATCH net-next v15 00/14] net: Make timestamping selectable patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240617182641.7fa3921e@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=j.vosburgh@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.