Re: [PATCH V2] drivers: pci: dwc: configure multiple atu regions

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240610235048.319266-1-shyamsaini@linux.microsoft.com>
References: <20240610235048.319266-1-shyamsaini@linux.microsoft.com>
TO: Shyam Saini <shyamsaini@linux.microsoft.com>
TO: jingoohan1@gmail.com
CC: Sergey.Semin@baikalelectronics.ru
CC: fancer.lancer@gmail.com
CC: manivannan.sadhasivam@linaro.org
CC: robh@kernel.org
CC: linux-pci@vger.kernel.org
CC: code@tyhicks.com
CC: apais@linux.microsoft.com
CC: bboscaccy@linux.microsoft.com
CC: okaya@kernel.org
CC: shyamsaini@linux.microsoft.com
CC: srivatsa@csail.mit.edu
CC: tballasi@linux.microsoft.com
CC: vijayb@linux.microsoft.com

Hi Shyam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on pci/for-linus]
[also build test WARNING on linus/master v6.10-rc4]
[cannot apply to pci/next next-20240613]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shyam-Saini/drivers-pci-dwc-configure-multiple-atu-regions/20240611-075252
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link:    https://lore.kernel.org/r/20240610235048.319266-1-shyamsaini%40linux.microsoft.com
patch subject: [PATCH V2] drivers: pci: dwc: configure multiple atu regions
:::::: branch date: 7 days ago
:::::: commit date: 7 days ago
config: i386-randconfig-141-20240616 (https://download.01.org/0day-ci/archive/20240618/202406180107.DRkw1UpJ-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202406180107.DRkw1UpJ-lkp@intel.com/

smatch warnings:
drivers/pci/controller/dwc/pcie-designware-host.c:679 dw_pcie_prog_outbound_atu_multi() error: uninitialized symbol 'ret'.

vim +/ret +679 drivers/pci/controller/dwc/pcie-designware-host.c

6bf4bd430cedf8 Shyam Saini 2024-06-10  659  
6bf4bd430cedf8 Shyam Saini 2024-06-10  660  static int dw_pcie_prog_outbound_atu_multi(struct dw_pcie *pci, int type,
6bf4bd430cedf8 Shyam Saini 2024-06-10  661  						struct resource_entry *entry)
6bf4bd430cedf8 Shyam Saini 2024-06-10  662  {
6bf4bd430cedf8 Shyam Saini 2024-06-10  663  	int idx, ret, num_regions;
6bf4bd430cedf8 Shyam Saini 2024-06-10  664  
6bf4bd430cedf8 Shyam Saini 2024-06-10  665  	num_regions = dw_pcie_num_atu_regions(entry);
6bf4bd430cedf8 Shyam Saini 2024-06-10  666  
6bf4bd430cedf8 Shyam Saini 2024-06-10  667  	for (idx = 0; idx < num_regions; idx++) {
6bf4bd430cedf8 Shyam Saini 2024-06-10  668  		dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, idx);
6bf4bd430cedf8 Shyam Saini 2024-06-10  669  		ret = dw_pcie_prog_outbound_atu(pci, idx, PCIE_ATU_TYPE_MEM,
6bf4bd430cedf8 Shyam Saini 2024-06-10  670  						entry->res->start,
6bf4bd430cedf8 Shyam Saini 2024-06-10  671  						entry->res->start - entry->offset,
6bf4bd430cedf8 Shyam Saini 2024-06-10  672  						resource_size(entry->res)/4);
6bf4bd430cedf8 Shyam Saini 2024-06-10  673  
6bf4bd430cedf8 Shyam Saini 2024-06-10  674  		if (ret)
6bf4bd430cedf8 Shyam Saini 2024-06-10  675  			goto err;
6bf4bd430cedf8 Shyam Saini 2024-06-10  676  	}
6bf4bd430cedf8 Shyam Saini 2024-06-10  677  
6bf4bd430cedf8 Shyam Saini 2024-06-10  678  err:
6bf4bd430cedf8 Shyam Saini 2024-06-10 @679  	return ret;
6bf4bd430cedf8 Shyam Saini 2024-06-10  680  }
6bf4bd430cedf8 Shyam Saini 2024-06-10  681  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki