From: Christoph Hellwig <hch@lst.de>
To: Barry Song <21cnbao@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Steve French <sfrench@samba.org>,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-mm@kvack.org, Barry Song <v-songbaohua@oppo.com>,
Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap
Date: Tue, 18 Jun 2024 08:13:40 +0200 [thread overview]
Message-ID: <20240618061340.GA28200@lst.de> (raw)
In-Reply-To: <CAGsJ_4xMzU2N=c-vtLv+vJwSJFcADjdaUONc=8yDTm52QabOXw@mail.gmail.com>
On Tue, Jun 18, 2024 at 06:05:33PM +1200, Barry Song wrote:
> Yes, that was exactly what I missed. I then figured it out, reproduced
> the issue,
> and discovered that the root cause was unrelated to large folios. It
> was actually
> due to a batched bio plugging optimization from 2022. You can find the new patch
> here:
>
> https://lore.kernel.org/linux-mm/20240617220135.43563-1-21cnbao@gmail.com/
I don't really see any point in keeping the VM_BUG_ON. The underlying
direct I/O code doesn't really care about the size at all.
next prev parent reply other threads:[~2024-06-18 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 10:03 fix swap on NFS Christoph Hellwig
2024-06-14 10:03 ` [PATCH] nfs: fix nfs_swap_rw for large-folio swap Christoph Hellwig
2024-06-14 17:52 ` Jeff Layton
2024-06-14 18:21 ` Andrew Morton
2024-06-16 0:16 ` Barry Song
2024-06-16 8:54 ` Christoph Hellwig
2024-06-16 10:23 ` Barry Song
2024-06-17 5:32 ` Christoph Hellwig
2024-06-17 8:02 ` Barry Song
2024-06-18 5:52 ` Christoph Hellwig
2024-06-18 6:05 ` Barry Song
2024-06-18 6:13 ` Christoph Hellwig [this message]
2024-06-18 6:31 ` Barry Song
2024-06-17 8:03 ` Ryan Roberts
2024-06-17 9:40 ` Barry Song
2024-06-17 10:33 ` Ryan Roberts
2024-06-18 6:48 ` Martin Wege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618061340.GA28200@lst.de \
--to=hch@lst.de \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anna@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sfrench@samba.org \
--cc=trondmy@kernel.org \
--cc=v-songbaohua@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.