From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jiri Pirko <jiri@resnulli.us>, Parav Pandit <parav@nvidia.com>,
Jason Wang <jasowang@redhat.com>, Cindy Lu <lulu@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/2] vdpa: support set mac address from vdpa tool
Date: Tue, 18 Jun 2024 06:39:21 -0400 [thread overview]
Message-ID: <20240618063613-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240617094421.4ae387d7@kernel.org>
On Mon, Jun 17, 2024 at 09:44:21AM -0700, Jakub Kicinski wrote:
> On Mon, 17 Jun 2024 12:20:19 -0400 Michael S. Tsirkin wrote:
> > > But the virtio spec doesn't allow setting the MAC...
> > > I'm probably just lost in the conversation but there's hypervisor side
> > > and there is user/VM side, each of them already has an interface to set
> > > the MAC. The MAC doesn't matter, but I want to make sure my mental model
> > > matches reality in case we start duplicating too much..
> >
> > An obvious part of provisioning is specifying the config space
> > of the device.
>
> Agreed, that part is obvious.
> Please go ahead, I don't really care and you clearly don't have time
> to explain.
Thanks!
Just in case Cindy who is working on it is also confused,
here is what I meant:
- an interface to provision a device, including its config
space, makes sense to me
- default mac address is part of config space, and would thus be covered
- note how this is different from ability to tweak the mac of an existing
device
--
MST
next prev parent reply other threads:[~2024-06-18 10:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:32 [PATCH 1/2] vdpa: support set mac address from vdpa tool Cindy Lu
2024-06-11 5:32 ` [PATCH 2/2] vdpa_sim_net: Add the support of set mac address Cindy Lu
2024-06-12 1:58 ` [PATCH 1/2] vdpa: support set mac address from vdpa tool Jakub Kicinski
2024-06-12 6:29 ` Jiri Pirko
2024-06-12 7:15 ` Michael S. Tsirkin
2024-06-12 7:22 ` Jiri Pirko
2024-06-13 6:49 ` Michael S. Tsirkin
2024-06-13 7:21 ` Jiri Pirko
2024-06-13 7:50 ` Michael S. Tsirkin
2024-06-13 14:46 ` Jiri Pirko
2024-06-17 1:48 ` Jason Wang
2024-06-17 2:57 ` Parav Pandit
2024-06-17 9:39 ` Jiri Pirko
2024-06-17 9:44 ` Parav Pandit
2024-06-17 11:39 ` Jiri Pirko
2024-06-17 11:48 ` Parav Pandit
2024-06-17 13:02 ` Jiri Pirko
2024-06-17 13:47 ` Michael S. Tsirkin
2024-06-17 15:20 ` Jakub Kicinski
2024-06-17 16:20 ` Michael S. Tsirkin
2024-06-17 16:44 ` Jakub Kicinski
2024-06-18 10:39 ` Michael S. Tsirkin [this message]
2024-06-19 13:10 ` Cindy Lu
2024-06-12 7:12 ` Michael S. Tsirkin
2024-06-13 6:44 ` Cindy Lu
2024-06-13 6:59 ` Michael S. Tsirkin
2024-06-13 13:29 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618063613-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.