From: Jakub Kicinski <kuba@kernel.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: core: Remove the dup_errno parameter in dev_prep_valid_name()
Date: Tue, 18 Jun 2024 07:48:40 -0700 [thread overview]
Message-ID: <20240618074840.536600bb@kernel.org> (raw)
In-Reply-To: <20240618131743.2690-1-yajun.deng@linux.dev>
On Tue, 18 Jun 2024 21:17:43 +0800 Yajun Deng wrote:
> netdev_name_in_use() return -EEXIST makes more sense if it's not NULL.
netdev_name_in_use() returns bool.
> But dev_alloc_name() should keep the -ENFILE errno.
And it does.
I don't understand what problem you're trying to fix.
The code is fine as is.
next prev parent reply other threads:[~2024-06-18 14:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 13:17 [PATCH net-next] net: core: Remove the dup_errno parameter in dev_prep_valid_name() Yajun Deng
2024-06-18 14:05 ` Jiri Pirko
2024-06-18 14:48 ` Jakub Kicinski [this message]
2024-06-19 1:55 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618074840.536600bb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.