From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: edward.cree@amd.com, linux-net-drivers@amd.com,
davem@davemloft.com, edumazet@google.com, pabeni@redhat.com,
Edward Cree <ecree.xilinx@gmail.com>,
netdev@vger.kernel.org, habetsm.xilinx@gmail.com,
sudheer.mogilappagari@intel.com, jdamato@fastly.com,
mw@semihalf.com, linux@armlinux.org.uk, sgoutham@marvell.com,
gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com,
saeedm@nvidia.com, leon@kernel.org, jacob.e.keller@intel.com,
andrew@lunn.ch, ahmed.zaki@intel.com
Subject: Re: [PATCH v5 net-next 1/7] net: move ethtool-related netdev state into its own struct
Date: Tue, 18 Jun 2024 17:21:03 -0700 [thread overview]
Message-ID: <20240618172103.312f1e24@kernel.org> (raw)
In-Reply-To: <5be9c248-8d63-4199-89ef-4cd9023604d7@davidwei.uk>
On Tue, 18 Jun 2024 16:45:56 -0700 David Wei wrote:
> >> dev->ethtool = NULL?
> >
> > defensive programming is sometimes permitted by not encouraged :)
>
> I've been here enough to know this bit!
>
> But, kfree(foo) followed by foo = NULL is a common pattern I see in
> kernel code. free_netdev() does it a bit further down. Is this pattern
> deprecated, then?
I wouldn't say its deprecated. But I'd certainly let the author choose
not to do this, especially on a straightforward path like free_netdev()
next prev parent reply other threads:[~2024-06-19 0:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 22:44 [PATCH v5 net-next 0/7] ethtool: track custom RSS contexts in the core edward.cree
2024-06-18 22:44 ` [PATCH v5 net-next 1/7] net: move ethtool-related netdev state into its own struct edward.cree
2024-06-18 23:05 ` David Wei
2024-06-18 23:43 ` Jakub Kicinski
2024-06-18 23:45 ` David Wei
2024-06-19 0:21 ` Jakub Kicinski [this message]
2024-06-18 22:44 ` [PATCH v5 net-next 2/7] net: ethtool: attach an XArray of custom RSS contexts to a netdevice edward.cree
2024-06-18 23:49 ` Jakub Kicinski
2024-06-19 14:30 ` Jakub Kicinski
2024-06-18 22:44 ` [PATCH v5 net-next 3/7] net: ethtool: record custom RSS contexts in the XArray edward.cree
2024-06-19 0:46 ` David Wei
2024-06-19 11:59 ` Edward Cree
2024-06-18 22:44 ` [PATCH v5 net-next 4/7] net: ethtool: let the core choose RSS context IDs edward.cree
2024-06-19 17:24 ` Jakub Kicinski
2024-06-19 20:08 ` Jakub Kicinski
2024-06-20 4:42 ` Edward Cree
2024-06-18 22:44 ` [PATCH v5 net-next 5/7] net: ethtool: add an extack parameter to new rxfh_context APIs edward.cree
2024-06-18 22:44 ` [PATCH v5 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts edward.cree
2024-06-18 22:44 ` [PATCH v5 net-next 7/7] sfc: use new rxfh_context API edward.cree
2024-06-19 0:19 ` [PATCH v5 net-next 0/7] ethtool: track custom RSS contexts in the core Jakub Kicinski
2024-06-19 12:00 ` Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618172103.312f1e24@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.com \
--cc=dw@davidwei.uk \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=gakula@marvell.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hkelam@marvell.com \
--cc=jacob.e.keller@intel.com \
--cc=jdamato@fastly.com \
--cc=leon@kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.