From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
"Thomas Huth" <thuth@linux.vnet.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>
Subject: Re: [PATCH 1/2] virtio_net: checksum offloading handling fix
Date: Tue, 18 Jun 2024 18:15:16 -0700 [thread overview]
Message-ID: <20240618181516.7d22421e@kernel.org> (raw)
In-Reply-To: <1718680142.7236671-11-hengqi@linux.alibaba.com>
On Tue, 18 Jun 2024 11:09:02 +0800 Heng Qi wrote:
> > (Should we manually do checksum if RXCUSM is disabled?)
> >
>
> Currently we do not allow RXCUSM to be disabled.
You don't have to disable checksuming in the device.
Just ignore VIRTIO_NET_HDR_F_DATA_VALID if user cleared NETIF_F_RXCSUM.
I know some paranoid workloads which do actually want the kernel to
calculate the checksum.
next prev parent reply other threads:[~2024-06-19 1:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 13:15 [PATCH 0/2] virtio_net: fixes for checksum offloading and XDP handling Heng Qi
2024-06-17 13:15 ` [PATCH 1/2] virtio_net: checksum offloading handling fix Heng Qi
2024-06-17 13:34 ` Jiri Pirko
2024-06-18 3:01 ` Jason Wang
2024-06-18 3:09 ` Heng Qi
2024-06-19 1:15 ` Jakub Kicinski [this message]
2024-06-19 2:02 ` Heng Qi
2024-06-19 15:08 ` Jakub Kicinski
2024-06-19 15:44 ` Heng Qi
2024-06-20 8:29 ` Jason Wang
2024-06-17 13:15 ` [PATCH 2/2] virtio_net: fixing XDP for fully checksummed packets handling Heng Qi
2024-06-18 3:10 ` Jason Wang
2024-06-18 3:15 ` Heng Qi
2024-06-20 8:33 ` Jason Wang
2024-06-20 9:28 ` Heng Qi
2024-06-20 10:19 ` Michael S. Tsirkin
2024-06-20 10:27 ` Heng Qi
2024-06-20 10:38 ` Heng Qi
2024-06-20 10:45 ` Michael S. Tsirkin
2024-06-19 10:00 ` [PATCH 0/2] virtio_net: fixes for checksum offloading and XDP handling patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618181516.7d22421e@kernel.org \
--to=kuba@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hawk@kernel.org \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.