All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: stable@vger.kernel.org, petrm@nvidia.com, liuhangbin@gmail.com,
	pabeni@redhat.com, kuba@kernel.org, bpoirier@nvidia.com,
	idosch@nvidia.com
Subject: Re: [PATCHv2 6.6.y 1/3] selftests/net: add lib.sh
Date: Wed, 19 Jun 2024 10:49:41 +0200	[thread overview]
Message-ID: <2024061911-crinkly-pointer-f564@gregkh> (raw)
In-Reply-To: <20240618075306.1073405-2-po-hsu.lin@canonical.com>

On Tue, Jun 18, 2024 at 03:53:04PM +0800, Po-Hsu Lin wrote:
> From: Hangbin Liu <liuhangbin@gmail.com>
> 
> commit 25ae948b447881bf689d459cd5bd4629d9c04b20 upstream.
> 
> Add a lib.sh for net selftests. This file can be used to define commonly
> used variables and functions. Some commonly used functions can be moved
> from forwarding/lib.sh to this lib file. e.g. busywait().
> 
> Add function setup_ns() for user to create unique namespaces with given
> prefix name.
> 
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  tools/testing/selftests/net/Makefile          |  2 +-
>  tools/testing/selftests/net/forwarding/lib.sh | 27 +--------
>  tools/testing/selftests/net/lib.sh            | 85 +++++++++++++++++++++++++++
>  3 files changed, 87 insertions(+), 27 deletions(-)
>  create mode 100644 tools/testing/selftests/net/lib.sh

This patch fails to apply on the lates 6.6.y tree:
	checking file tools/testing/selftests/net/Makefile
	Hunk #1 FAILED at 54.
	1 out of 1 hunk FAILED
	checking file tools/testing/selftests/net/forwarding/lib.sh
	checking file tools/testing/selftests/net/lib.sh

Please rebase and resubmit.

thanks,

greg k-h

  reply	other threads:[~2024-06-19  8:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  7:53 [PATCHv2 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests Po-Hsu Lin
2024-06-18  7:53 ` [PATCHv2 6.6.y 1/3] selftests/net: add lib.sh Po-Hsu Lin
2024-06-19  8:49   ` Greg KH [this message]
2024-06-18  7:53 ` [PATCHv2 6.6.y 2/3] selftests/net: add variable NS_LIST for lib.sh Po-Hsu Lin
2024-06-18  7:53 ` [PATCHv2 6.6.y 3/3] selftests: forwarding: Avoid failures to source net/lib.sh Po-Hsu Lin
2024-06-18  9:19 ` [PATCHv2 6.6.y 0/3] Fix missing lib.sh for net/unicast_extensions.sh and net/pmtu.sh tests Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024061911-crinkly-pointer-f564@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=bpoirier@nvidia.com \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=po-hsu.lin@canonical.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.