Re: [yocto-patches] [meta-rockchip][PATCH 4/4] rauc demo: add

[Trevor Woerner <twoerner@gmail.com>]

On Wed 2024-06-19 @ 01:55:59 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> Hi Trevor,
> 
> On 6/19/24 6:52 AM, Trevor Woerner via lists.yoctoproject.org wrote:
> [...]
> > > > diff --git a/classes-recipe/rk-rauc-demo.bbclass b/classes-recipe/rk-rauc-demo.bbclass
> > > > new file mode 100644
> > > > index 000000000000..25e105b53d09
> > > > --- /dev/null
> > > > +++ b/classes-recipe/rk-rauc-demo.bbclass
> > > > @@ -0,0 +1,8 @@
> > > > +inherit features_check
> > > > +
> > > > +REQUIRED_DISTRO_FEATURES += "systemd rauc"
> > > > +REQUIRED_MACHINE_FEATURES += "rk-u-boot-env"
> > > > +
> > > > +# 'RK_RAUC_DEMO' indicates the user wants to use the
> > > > +# rauc demo configuration from this layer
> > > > +OVERRIDES .= "${@ ':rk-rauc-demo' if bb.utils.to_boolean(d.getVar('RK_RAUC_DEMO'), False) else ''}"
> > > 
> > > This very much smells like we should have a DISTRO for this instead no? What
> > > made you decide to go for a class?
> > > 
> > > Also, why is here and also in the global class just below? This should be in
> > > the global class only to apply to all recipes?
> > 
> > I want the build to fail if the user doesn't enable "rk-u-boot-env" in
> > MACHINE_FEATURES; you can't do RAUC if you can't save the U-Boot environment.
> > Second I want the build to fail if the user doesn't specify "rauc" in
> > DISTRO_FEATURES; the RAUC layer doens't work unless this is enabled. Therefore
> > I want to do a features_check somewhere, and the way features_check is
> > implemented means you need a class (?), specifically you need a classes-recipe
> > bbclass.
> > 
> > If you do a features_check in classes/ it will fail because feature_check is
> > is oe-core's classes-recipe and it won't be found from a bbclass in classes/.
> > Perhaps I did it wrong, but this is what I found.
> > 
> > Secondly if you look in meta-rauc you see that they're using a similar class
> > mechanism for the "rauc" override, is that not a common idiom? I'm simply
> > following that example with meta-rockchip's "rk-rauc-demo" override. If
> > there's a better way I'm happy to try it.
> > 
> 
> Can you point at some files? git grep OVERRIDES and git grep features_check
> returns nothing in the master branch of meta-rauc, so I probably am not
> looking in the right places or with the right terms.

Oops, I meant meta-rauc-community, and I was referring to just the overrides
thing, not the features_check thing:

https://github.com/rauc/meta-rauc-community/blob/master/meta-rauc-raspberrypi/classes/rauc-integration.bbclass

> [...]
> > On the other hand, if you're trying to understand what the partitions are and
> > what's available where and with what options, isn't /etc/fstab the first thing
> > you look at?
> > 
> 
> I run `mount` on my running target :)
> 
> Cheers,
> Quentin
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#350): https://lists.yoctoproject.org/g/yocto-patches/message/350
> Mute This Topic: https://lists.yoctoproject.org/mt/106253218/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>