From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCHv2] nvme-tcp: align I/O cpu with blk-mq mapping
Date: Wed, 19 Jun 2024 16:59:58 +0200 [thread overview]
Message-ID: <20240619145958.GA2254@lst.de> (raw)
In-Reply-To: <20240619145553.89736-1-hare@kernel.org>
> if (wq_unbound)
> queue->io_cpu = WORK_CPU_UNBOUND;
None of the above computed information is even used for the wq_unbound
code. This would make a lot more sense if the above assignment was in
the (only) caller.
Yes, that probably should have been done when merging the wq_unbound
option (which honestly looks so whacky that I wish it wasn't merged).
next prev parent reply other threads:[~2024-06-19 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 14:55 [PATCHv2] nvme-tcp: align I/O cpu with blk-mq mapping Hannes Reinecke
2024-06-19 14:59 ` Christoph Hellwig [this message]
2024-06-19 15:23 ` Hannes Reinecke
2024-06-19 15:43 ` Sagi Grimberg
2024-06-19 15:49 ` Hannes Reinecke
2024-06-19 15:58 ` Sagi Grimberg
2024-06-24 10:02 ` Sagi Grimberg
2024-06-24 20:01 ` Kamaljit Singh
2024-06-25 6:49 ` Sagi Grimberg
2024-06-25 6:05 ` Hannes Reinecke
2024-06-25 6:51 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619145958.GA2254@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.