From: Jakub Kicinski <kuba@kernel.org>
To: Danielle Ratson <danieller@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <corbet@lwn.net>,
<linux@armlinux.org.uk>, <sdf@google.com>,
<kory.maincent@bootlin.com>, <maxime.chevallier@bootlin.com>,
<vladimir.oltean@nxp.com>, <przemyslaw.kitszel@intel.com>,
<ahmed.zaki@intel.com>, <richardcochran@gmail.com>,
<shayagr@amazon.com>, <paul.greenwalt@intel.com>,
<jiri@resnulli.us>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mlxsw@nvidia.com>,
<idosch@nvidia.com>, <petrm@nvidia.com>
Subject: Re: [PATCH net-next v6 9/9] ethtool: Add ability to flash transceiver modules' firmware
Date: Wed, 19 Jun 2024 18:35:00 -0700 [thread overview]
Message-ID: <20240619183500.5635a7a1@kernel.org> (raw)
In-Reply-To: <20240619121727.3643161-10-danieller@nvidia.com>
On Wed, 19 Jun 2024 15:17:27 +0300 Danielle Ratson wrote:
> + switch (sk_priv->type) {
> + case ETHTOOL_SOCK_TYPE_MODULE_FW_FLASH:
> + ethnl_module_fw_flash_sock_destroy(sk_priv);
> + default:
> + break;
The compilers are nit picking on this:
net/ethtool/netlink.c:57:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
57 | default:
| ^
net/ethtool/netlink.c:57:2: note: insert 'break;' to avoid fall-through
57 | default:
| ^
--
pw-bot: cr
next prev parent reply other threads:[~2024-06-20 1:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 12:17 [PATCH net-next v6 0/9] Add ability to flash modules' firmware Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 1/9] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 2/9] mlxsw: Implement " Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 3/9] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 4/9] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-06-20 19:30 ` Simon Horman
2024-06-19 12:17 ` [PATCH net-next v6 5/9] ethtool: Veto some operations during firmware flashing process Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 6/9] net: sfp: Add more extended compliance codes Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 7/9] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 8/9] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-06-19 12:17 ` [PATCH net-next v6 9/9] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
2024-06-20 1:35 ` Jakub Kicinski [this message]
2024-06-21 6:55 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2024-06-21 4:27 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619183500.5635a7a1@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sdf@google.com \
--cc=shayagr@amazon.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.