From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28AAF14C581 for ; Wed, 19 Jun 2024 13:48:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718804923; cv=none; b=Qy3lREgx7LNJQZIgWaPzeyhAzwjXvGeBbQMNtc+Va5jEItjQa4nfAbAded0Uov6+C63WzdbLmez8gllXoHDo2b7VlWSZ/WwI3oqs43aditNNzNIoAxR7ddYh3hADqFexOFFzTcBQLb8+hWpY09w2rDV6YtH/xwrhEIy0I8awFf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718804923; c=relaxed/simple; bh=WtWASmI5JHElIz7JmWBOAHv+C0x7EW10I+SHxWthetM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=g1SxdErU10m8MGoh3xWZsYFOcZoVeuL8qoPOvrtlnfOXM3YYWXJEKPacfslCbqkNUC8e0dVvj40gpYnUB9HjhyrkrqmR/3fti8Z35x7t4zJMDQaM3f4t0+cquXkQND16jIt8ZLIt8FBdGjUqC1F5LjmCPVMYaa2IuyTPuZ4Nnho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Wz2vV+Ww; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Wz2vV+Ww" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1EFDC2BBFC; Wed, 19 Jun 2024 13:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718804923; bh=WtWASmI5JHElIz7JmWBOAHv+C0x7EW10I+SHxWthetM=; h=From:To:Cc:Subject:Date:Reply-to:From; b=Wz2vV+WwX4Mx8LflXu1GUHlKHD267k27B+wzrrzzAJIKQ+hguoYl+J3lbbnwhVR0p IBdhIWJdSmme7rNs0pdqF4RJrsZMzsQG6EhsdrBJWIzSu6NGJw/tZpaywLeSp4gU0j q+p1UwI4oa9qlTgrrnzpCcJXvS8qkJGUyoIQNazc= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-38605: ALSA: core: Fix NULL module pointer assignment at card init Date: Wed, 19 Jun 2024 15:48:28 +0200 Message-ID: <2024061925-CVE-2024-38605-3dc4@gregkh> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=3794; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=WtWASmI5JHElIz7JmWBOAHv+C0x7EW10I+SHxWthetM=; b=owGbwMvMwCRo6H6F97bub03G02pJDGlFD1fOd1y+6u38kGaV1i8H5q1Ta6z83n3f64SY3mYBR 4nT5yx4OmJZGASZGGTFFFm+bOM5ur/ikKKXoe1pmDmsTCBDGLg4BWAif68zLOjLvnQocbKvW/el yHXeiasYJExj0hgWdE83877iGiOYcm9T0dOsrsMyrSp3AQ== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: ALSA: core: Fix NULL module pointer assignment at card init The commit 81033c6b584b ("ALSA: core: Warn on empty module") introduced a WARN_ON() for a NULL module pointer passed at snd_card object creation, and it also wraps the code around it with '#ifdef MODULE'. This works in most cases, but the devils are always in details. "MODULE" is defined when the target code (i.e. the sound core) is built as a module; but this doesn't mean that the caller is also built-in or not. Namely, when only the sound core is built-in (CONFIG_SND=y) while the driver is a module (CONFIG_SND_USB_AUDIO=m), the passed module pointer is ignored even if it's non-NULL, and card->module remains as NULL. This would result in the missing module reference up/down at the device open/close, leading to a race with the code execution after the module removal. For addressing the bug, move the assignment of card->module again out of ifdef. The WARN_ON() is still wrapped with ifdef because the module can be really NULL when all sound drivers are built-in. Note that we keep 'ifdef MODULE' for WARN_ON(), otherwise it would lead to a false-positive NULL module check. Admittedly it won't catch perfectly, i.e. no check is performed when CONFIG_SND=y. But, it's no real problem as it's only for debugging, and the condition is pretty rare. The Linux kernel CVE team has assigned CVE-2024-38605 to this issue. Affected and fixed versions =========================== Issue introduced in 5.9 with commit 81033c6b584b and fixed in 5.10.219 with commit d7ff29a429b5 Issue introduced in 5.9 with commit 81033c6b584b and fixed in 5.15.161 with commit e7e0ca200772 Issue introduced in 5.9 with commit 81033c6b584b and fixed in 6.1.93 with commit e00747672573 Issue introduced in 5.9 with commit 81033c6b584b and fixed in 6.6.33 with commit e644036a3e2b Issue introduced in 5.9 with commit 81033c6b584b and fixed in 6.8.12 with commit c935e72139e6 Issue introduced in 5.9 with commit 81033c6b584b and fixed in 6.9.3 with commit 6b8374ee2cab Issue introduced in 5.9 with commit 81033c6b584b and fixed in 6.10-rc1 with commit 39381fe7394e Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-38605 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: sound/core/init.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/d7ff29a429b56f04783152ad7bbd7233b740e434 https://git.kernel.org/stable/c/e7e0ca200772bdb2fdc6d43d32d341e87a36f811 https://git.kernel.org/stable/c/e007476725730c1a68387b54b7629486d8a8301e https://git.kernel.org/stable/c/e644036a3e2b2c9b3eee3c61b5d31c2ca8b5ba92 https://git.kernel.org/stable/c/c935e72139e6d523defd60fe875c01eb1f9ea5c5 https://git.kernel.org/stable/c/6b8374ee2cabcf034faa34e69a855dc496a9ec12 https://git.kernel.org/stable/c/39381fe7394e5eafac76e7e9367e7351138a29c1