Re: [PATCH 2/3] dt-bindings: arm: mediatek: Add MT8186 Voltorb Chromebooks

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]

On Thu, Jun 20, 2024 at 05:47:37PM +0800, Chen-Yu Tsai wrote:
> Add an entry for the MT8186 based Voltorb Chromebooks, also known as the
> Acer Chromebook 311 (C723/C723T). The device is a clamshell style laptop
> with an optional touchscreen.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index b1b09db0bd65..e7746afeb0b3 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -301,6 +301,13 @@ properties:
>            - const: google,tentacruel-sku327683
>            - const: google,tentacruel
>            - const: mediatek,mt8186
> +      - description: Google Voltorb (Acer Chromebook 311 C723/C732T)
> +        items:
> +          - enum:
> +              - google,voltorb-sku589824
> +              - google,voltorb-sku589825

This looks rather sane for a chromebook!
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +          - const: google,voltorb
> +          - const: mediatek,mt8186
>        - items:
>            - enum:
>                - mediatek,mt8186-evb
> -- 
> 2.45.2.741.gdbec12cfda-goog
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]