Re: [PATCH v2 11/19] media: renesas: vsp1: Add and use function to dump a pipeline to the log

[kernel test robot <lkp@intel.com>]

Hi Laurent,

kernel test robot noticed the following build errors:

[auto build test ERROR on 91798162245991e26949ef62851719bb2177a9c2]

url:    https://github.com/intel-lab-lkp/linux/commits/Laurent-Pinchart/media-renesas-vsp1-Drop-vsp1_entity_get_pad_format-wrapper/20240619-081928
base:   91798162245991e26949ef62851719bb2177a9c2
patch link:    https://lore.kernel.org/r/20240619001722.9749-12-laurent.pinchart%2Brenesas%40ideasonboard.com
patch subject: [PATCH v2 11/19] media: renesas: vsp1: Add and use function to dump a pipeline to the log
config: arm-shmobile_defconfig (https://download.01.org/0day-ci/archive/20240620/202406200018.1RpJIl3K-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406200018.1RpJIl3K-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406200018.1RpJIl3K-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from drivers/media/platform/renesas/vsp1/vsp1_drm.h:18,
                    from drivers/media/platform/renesas/vsp1/vsp1_drm.c:21:
   drivers/media/platform/renesas/vsp1/vsp1_drm.c: In function 'vsp1_du_setup_lif':
>> drivers/media/platform/renesas/vsp1/vsp1_pipe.h:161:1: error: expected statement before ')' token
     161 | )}
         | ^
   drivers/media/platform/renesas/vsp1/vsp1_drm.c:736:9: note: in expansion of macro 'vsp1_pipeline_dump'
     736 |         vsp1_pipeline_dump(pipe, "LIF setup");
         |         ^~~~~~~~~~~~~~~~~~
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:736:46: error: expected ')' before ';' token
     736 |         vsp1_pipeline_dump(pipe, "LIF setup");
         |                                              ^
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:770:18: error: expected ';' before '}' token
     770 |         return 0;
         |                  ^
         |                  ;
     771 | }
         | ~                 
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:734:17: error: label 'unlock' used but not defined
     734 |                 goto unlock;
         |                 ^~~~
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:650:23: warning: unused variable 'flags' [-Wunused-variable]
     650 |         unsigned long flags;
         |                       ^~~~~
   drivers/media/platform/renesas/vsp1/vsp1_drm.c: In function 'vsp1_du_atomic_flush':
>> drivers/media/platform/renesas/vsp1/vsp1_pipe.h:161:1: error: expected statement before ')' token
     161 | )}
         | ^
   drivers/media/platform/renesas/vsp1/vsp1_drm.c:912:9: note: in expansion of macro 'vsp1_pipeline_dump'
     912 |         vsp1_pipeline_dump(pipe, "atomic update");
         |         ^~~~~~~~~~~~~~~~~~
   drivers/media/platform/renesas/vsp1/vsp1_drm.c:912:50: error: expected ')' before ';' token
     912 |         vsp1_pipeline_dump(pipe, "atomic update");
         |                                                  ^
   drivers/media/platform/renesas/vsp1/vsp1_drm.c:917:40: error: expected ';' before '}' token
     917 |         mutex_unlock(&vsp1->drm->lock);
         |                                        ^
         |                                        ;
     918 | }
         | ~                                       
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:902:25: error: label 'done' used but not defined
     902 |                         goto done;
         |                         ^~~~
   drivers/media/platform/renesas/vsp1/vsp1_drm.c: In function 'vsp1_du_setup_lif':
>> drivers/media/platform/renesas/vsp1/vsp1_drm.c:771:1: warning: control reaches end of non-void function [-Wreturn-type]
     771 | }
         | ^
--
   In file included from drivers/media/platform/renesas/vsp1/vsp1_video.c:32:
   drivers/media/platform/renesas/vsp1/vsp1_video.c: In function 'vsp1_video_pipeline_init':
>> drivers/media/platform/renesas/vsp1/vsp1_pipe.h:161:1: error: expected statement before ')' token
     161 | )}
         | ^
   drivers/media/platform/renesas/vsp1/vsp1_video.c:533:9: note: in expansion of macro 'vsp1_pipeline_dump'
     533 |         vsp1_pipeline_dump(pipe, "video");
         |         ^~~~~~~~~~~~~~~~~~
>> drivers/media/platform/renesas/vsp1/vsp1_video.c:533:42: error: expected ')' before ';' token
     533 |         vsp1_pipeline_dump(pipe, "video");
         |                                          ^
>> drivers/media/platform/renesas/vsp1/vsp1_video.c:535:18: error: expected ';' before '}' token
     535 |         return 0;
         |                  ^
         |                  ;
     536 | }
         | ~                 
>> drivers/media/platform/renesas/vsp1/vsp1_video.c:536:1: warning: control reaches end of non-void function [-Wreturn-type]
     536 | }
         | ^


vim +161 drivers/media/platform/renesas/vsp1/vsp1_pipe.h

   145	
   146	void __vsp1_pipeline_dump(struct _ddebug *, struct vsp1_pipeline *pipe,
   147				  const char *msg);
   148	
   149	#if defined(CONFIG_DYNAMIC_DEBUG) || \
   150		(defined(CONFIG_DYNAMIC_DEBUG_CORE) && defined(DYNAMIC_DEBUG_MODULE))
   151	#define vsp1_pipeline_dump(pipe, msg)			\
   152		_dynamic_func_call("vsp1_pipeline_dump()", __vsp1_pipeline_dump, pipe, msg)
   153	#elif defined(DEBUG)
   154	#define vsp1_pipeline_dump(pipe, msg)			\
   155		__vsp1_pipeline_dump(NULL, pipe, msg)
   156	#else
   157	#define vsp1_pipeline_dump(pipe, msg)			\
   158	({							\
   159		if (0)						\
   160			__vsp1_pipeline_dump(NULL, pipe, msg);	\
 > 161	)}
   162	#endif
   163	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki