Re: [RFC PATCH] cxl: avoid duplicating report from MCE & device

[kernel test robot <lkp@intel.com>]

Hi Shiyang,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on cxl/next]
[also build test ERROR on linus/master v6.10-rc4 next-20240619]
[cannot apply to tip/x86/core cxl/pending]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shiyang-Ruan/cxl-avoid-duplicating-report-from-MCE-device/20240619-011058
base:   https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git next
patch link:    https://lore.kernel.org/r/20240618165310.877974-1-ruansy.fnst%40fujitsu.com
patch subject: [RFC PATCH] cxl: avoid duplicating report from MCE & device
config: x86_64-randconfig-006-20240619 (https://download.01.org/0day-ci/archive/20240620/202406200104.23DAmKcD-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240620/202406200104.23DAmKcD-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406200104.23DAmKcD-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/cxl/core/mbox.o: in function `cxl_memdev_state_create':
>> drivers/cxl/core/mbox.c:1558:(.text+0xb23): undefined reference to `mce_register_decode_chain'
   ld: drivers/cxl/core/mbox.o: in function `cxl_handle_mce':
>> drivers/cxl/core/mbox.c:1516:(.text+0x25e2): undefined reference to `mce_usable_address'


vim +1558 drivers/cxl/core/mbox.c

  1507	
  1508	static int cxl_handle_mce(struct notifier_block *nb, unsigned long val,
  1509				  void *data)
  1510	{
  1511		struct mce *mce = (struct mce *)data;
  1512		struct cxl_memdev_state *mds = container_of(nb, struct cxl_memdev_state,
  1513							    mce_notifier);
  1514		u64 hpa;
  1515	
> 1516		if (!mce || !mce_usable_address(mce))
  1517			return NOTIFY_DONE;
  1518	
  1519		hpa = mce->addr & MCI_ADDR_PHYSADDR;
  1520	
  1521		/* Check if the PFN is located on this CXL device */
  1522		if (!pfn_valid(hpa >> PAGE_SHIFT) &&
  1523		    !cxl_contains_hpa(mds->cxlds.cxlmd, hpa))
  1524			return NOTIFY_DONE;
  1525	
  1526		/*
  1527		 * Search PFN in the cxl_mce_records, if already exists, don't continue
  1528		 * to do memory_failure() to avoid a poison address being reported
  1529		 * more than once.
  1530		 */
  1531		if (cxl_mce_recorded(hpa))
  1532			return NOTIFY_STOP;
  1533		else
  1534			return NOTIFY_OK;
  1535	}
  1536	
  1537	struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev)
  1538	{
  1539		struct cxl_memdev_state *mds;
  1540	
  1541		mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL);
  1542		if (!mds) {
  1543			dev_err(dev, "No memory available\n");
  1544			return ERR_PTR(-ENOMEM);
  1545		}
  1546	
  1547		mutex_init(&mds->mbox_mutex);
  1548		mutex_init(&mds->event.log_lock);
  1549		mds->cxlds.dev = dev;
  1550		mds->cxlds.reg_map.host = dev;
  1551		mds->cxlds.reg_map.resource = CXL_RESOURCE_NONE;
  1552		mds->cxlds.type = CXL_DEVTYPE_CLASSMEM;
  1553		mds->ram_perf.qos_class = CXL_QOS_CLASS_INVALID;
  1554		mds->pmem_perf.qos_class = CXL_QOS_CLASS_INVALID;
  1555	
  1556		mds->mce_notifier.notifier_call = cxl_handle_mce;
  1557		mds->mce_notifier.priority = MCE_PRIO_CXL;
> 1558		mce_register_decode_chain(&mds->mce_notifier);
  1559	
  1560		return mds;
  1561	}
  1562	EXPORT_SYMBOL_NS_GPL(cxl_memdev_state_create, CXL);
  1563	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki