From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev,
Chris Morgan <macroalpha82@gmail.com>,
Ryan Walklin <ryan@testtoast.com>,
Philippe Simons <simons.philippe@gmail.com>
Subject: Re: [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range
Date: Thu, 20 Jun 2024 10:27:53 +0100 [thread overview]
Message-ID: <20240620092753.GG3029315@google.com> (raw)
In-Reply-To: <20240613233104.17529-1-andre.przywara@arm.com>
On Fri, 14 Jun 2024, Andre Przywara wrote:
> While we list the "IRQ status *and acknowledge*" registers as volatile
> in the MFD description, they are missing from the writable range array,
> so acknowledging any interrupts was met with an -EIO error.
> This error propagates up, leading to the whole AXP717 driver failing to
> probe, which is fatal to most systems using this PMIC, since most
> peripherals refer one of the PMIC voltage rails.
> This wasn't noticed on the initial submission, since the interrupt was
> completely missing at this point, but the DTs now merged describe the
> interrupt, creating the problem.
>
> Add the five registers that hold those bits to the writable array.
>
> This fixes the boot on the Anbernic systems using the AXP717 PMIC.
>
> Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
> Reported-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> Hi,
>
> the patch itself is unchanged from v2 sent in April, but the commit
> message was updated to give rationale for the Fixes: tag.
> Please take this as a fix into v6.10.
>
> Thanks,
> Andre
>
> drivers/mfd/axp20x.c | 1 +
> 1 file changed, 1 insertion(+)
Submitted to Linus today.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2024-06-20 9:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 23:31 [PATCH v3] mfd: axp20x: AXP717: Fix missing IRQ status registers range Andre Przywara
2024-06-14 7:43 ` (subset) " Lee Jones
2024-06-20 9:27 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620092753.GG3029315@google.com \
--to=lee@kernel.org \
--cc=andre.przywara@arm.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=ryan@testtoast.com \
--cc=simons.philippe@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.