From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D2F2594; Thu, 20 Jun 2024 10:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718879641; cv=none; b=lw7BqYXNmSNHFmuDxO1/cGgceY2zG2tR1G5TsXou84em1IA2FUEFupJS/GQUCJOxG9rC+ZpJeOElFn/Pk/NgZYMfHnKieDV+9RaY/OsGmOsEOkgScBmIp3duaJw4r9sd3+upnj9LcfhPC6CGtuuN8uBuTkHCXmqMFsqVAWZ7ZWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718879641; c=relaxed/simple; bh=HShNafy3kcrdH/pYm/qzr0SfI1ZGqiTlGUQzNoPyLqc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y/qH0gekFIjSfXR75Ee/0lvmEbdRnC7Lyys5mq6bgrDyFTA1dm1cI/1mnAZs1EciQjz3aR0PosyUlJB3p2Ckr/wzau8YLy4WxUUJuy/MORLKLgPo6Mpw/G/jWBsQWkt5SRNKdnwAdyswJUnbfZoGBtR+lf6Jb3nJ94SzGaJ/aJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ATnmfz0a; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ATnmfz0a" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 92D8966F; Thu, 20 Jun 2024 12:33:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1718879618; bh=HShNafy3kcrdH/pYm/qzr0SfI1ZGqiTlGUQzNoPyLqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ATnmfz0aOnKlDcZ/w5vfw0GVZOGh2cCpcMFoXuytz9U8jOqc8rm69zStK8q5s/q5Y FY+oRlewL9Us0L7jEtKstTSZEuNX7IsicKPQPueZ9bLyjW/ZZcOLNWtVaAiSIqEoIY eu8hpUjfresfwvotkIhLh4xksTwvoP9GioFWjsa8= Date: Thu, 20 Jun 2024 13:33:35 +0300 From: Laurent Pinchart To: Kory Maincent Cc: Sakari Ailus , Paul Elder , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Mauro Carvalho Chehab Subject: Re: [PATCH] media: i2c: Kconfig: Fix missing firmware upload config select Message-ID: <20240620103335.GA27999@pendragon.ideasonboard.com> References: <20240620102544.1918105-1-kory.maincent@bootlin.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240620102544.1918105-1-kory.maincent@bootlin.com> Hi Kory, Thank you for the patch. On Thu, Jun 20, 2024 at 12:25:43PM +0200, Kory Maincent wrote: > FW_LOADER config only selects the firmware loader API, but we also need > the sysfs_upload symbols for firmware_upload_unregister() and > firmware_upload_register() to function properly. > > Fixes: 7a52ab415b43 ("media: i2c: Add driver for THine THP7312") > Signed-off-by: Kory Maincent Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index c6d3ee472d81..742bc665602e 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -679,6 +679,7 @@ config VIDEO_THP7312 > tristate "THine THP7312 support" > depends on I2C > select FW_LOADER > + select FW_UPLOAD > select MEDIA_CONTROLLER > select V4L2_CCI_I2C > select V4L2_FWNODE -- Regards, Laurent Pinchart