From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: lkp@intel.com, "Paul Cercueil" <paul@crapouillou.net>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, dmaengine@vger.kernel.org,
linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org,
"Christian König" <christian.koenig@amd.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Vinod Koul" <vkoul@kernel.org>,
oe-kbuild-all@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, "Jonathan Corbet" <corbet@lwn.net>,
"Julia Lawall" <julia.lawall@inria.fr>,
"Randy Dunlap" <rdunlap@infradead.org>
Subject: Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure
Date: Thu, 20 Jun 2024 17:55:43 +0100 [thread overview]
Message-ID: <20240620165543.GR3029315@google.com> (raw)
In-Reply-To: <ca3efef9-9720-46be-a59d-a9a4c5873ea2@web.de>
On Thu, 20 Jun 2024, Markus Elfring wrote:
> …
> > v11:
> …
> > - Use guard(mutex)
> >
> > v12:
> > - Revert to mutex_lock/mutex_unlock in iio_buffer_attach_dmabuf(),
> > as it uses cleanup GOTOs
> …
>
> I would find it nice if better design options could gain acceptance.
> Will the chances grow to adjust scopes another bit for involved variables
> in such function implementations?
>
> A) Enclosing a source code part with extra curly brackets?
>
> B) scoped_guard()?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L137
>
> C) Moving a locked source code part into a separate function implementation?
I think it would help your cause if you quoted the exact piece of code
you're referring to. Then tone down the language a bit - keep it as
simple and natural as you can.
Ex 1: Please place curly brackets around this section to aid with <reason>
Ex 2: To save N lines of clean-up, please use scoped_guard()
Ex 3: Moving out this chunk to another function would help with <reason>
Etc.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-20 16:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 12:27 [PATCH v12 0/7] iio: new DMABUF based API v12 Paul Cercueil
2024-06-20 12:27 ` [PATCH v12 1/7] dmaengine: Add API function dmaengine_prep_peripheral_dma_vec() Paul Cercueil
2024-06-20 12:27 ` [PATCH v12 2/7] dmaengine: dma-axi-dmac: Implement device_prep_peripheral_dma_vec Paul Cercueil
2024-06-20 12:27 ` [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure Paul Cercueil
2024-06-20 16:32 ` Markus Elfring
2024-06-20 16:55 ` Lee Jones [this message]
2024-06-20 12:27 ` [PATCH v12 4/7] iio: buffer-dma: Enable support for DMABUFs Paul Cercueil
2024-06-20 12:27 ` [PATCH v12 5/7] iio: buffer-dmaengine: Support new DMABUF based userspace API Paul Cercueil
2024-06-20 12:27 ` [PATCH v12 6/7] Documentation: iio: Document high-speed DMABUF based API Paul Cercueil
2024-06-20 14:08 ` Bagas Sanjaya
2024-06-20 12:27 ` [PATCH v12 7/7] Documentation: dmaengine: Document new dma_vec API Paul Cercueil
2024-06-20 16:20 ` [PATCH v12 0/7] iio: new DMABUF based API v12 Vinod Koul
2024-06-20 19:11 ` Jonathan Cameron
2024-06-20 19:14 ` Jonathan Cameron
2024-06-21 10:08 ` Vinod Koul
2024-06-21 10:10 ` Vinod Koul
2024-06-21 10:06 ` (subset) " Vinod Koul
2024-06-30 10:32 ` Jonathan Cameron
2024-06-30 13:05 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620165543.GR3029315@google.com \
--to=lee@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dmaengine@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=julia.lawall@inria.fr \
--cc=lars@metafoo.de \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=paul@crapouillou.net \
--cc=rdunlap@infradead.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.