From: Jiaqi Yan <jiaqiyan@google.com>
To: nao.horiguchi@gmail.com, linmiaohe@huawei.com,
jane.chu@oracle.com, osalvador@suse.de
Cc: muchun.song@linux.dev, akpm@linux-foundation.org,
shuah@kernel.org, corbet@lwn.net, rientjes@google.com,
duenwen@google.com, fvdl@google.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
Jiaqi Yan <jiaqiyan@google.com>
Subject: [PATCH v4 1/4] mm/memory-failure: refactor log format in soft offline code
Date: Thu, 20 Jun 2024 18:48:53 +0000 [thread overview]
Message-ID: <20240620184856.600717-2-jiaqiyan@google.com> (raw)
In-Reply-To: <20240620184856.600717-1-jiaqiyan@google.com>
Logs from soft_offline_page and soft_offline_in_use_page have
different formats than majority of the memory failure code:
"Memory failure: 0x${pfn}: ${lower_case_message}"
Convert them to the following format:
"Soft offline: 0x${pfn}: ${lower_case_message}"
No functional change in this commit.
Signed-off-by: Jiaqi Yan <jiaqiyan@google.com>
---
mm/memory-failure.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index d3c830e817e3..2a097af7da0e 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2631,6 +2631,9 @@ int unpoison_memory(unsigned long pfn)
}
EXPORT_SYMBOL(unpoison_memory);
+#undef pr_fmt
+#define pr_fmt(fmt) "Soft offline: " fmt
+
static bool mf_isolate_folio(struct folio *folio, struct list_head *pagelist)
{
bool isolated = false;
@@ -2686,7 +2689,7 @@ static int soft_offline_in_use_page(struct page *page)
if (!huge && folio_test_large(folio)) {
if (try_to_split_thp_page(page)) {
- pr_info("soft offline: %#lx: thp split failed\n", pfn);
+ pr_info("%#lx: thp split failed\n", pfn);
return -EBUSY;
}
folio = page_folio(page);
@@ -2698,7 +2701,7 @@ static int soft_offline_in_use_page(struct page *page)
if (PageHWPoison(page)) {
folio_unlock(folio);
folio_put(folio);
- pr_info("soft offline: %#lx page already poisoned\n", pfn);
+ pr_info("%#lx page already poisoned\n", pfn);
return 0;
}
@@ -2711,7 +2714,7 @@ static int soft_offline_in_use_page(struct page *page)
folio_unlock(folio);
if (ret) {
- pr_info("soft_offline: %#lx: invalidated\n", pfn);
+ pr_info("%#lx: invalidated\n", pfn);
page_handle_poison(page, false, true);
return 0;
}
@@ -2728,13 +2731,13 @@ static int soft_offline_in_use_page(struct page *page)
if (!list_empty(&pagelist))
putback_movable_pages(&pagelist);
- pr_info("soft offline: %#lx: %s migration failed %ld, type %pGp\n",
+ pr_info("%#lx: %s migration failed %ld, type %pGp\n",
pfn, msg_page[huge], ret, &page->flags);
if (ret > 0)
ret = -EBUSY;
}
} else {
- pr_info("soft offline: %#lx: %s isolation failed, page count %d, type %pGp\n",
+ pr_info("%#lx: %s isolation failed, page count %d, type %pGp\n",
pfn, msg_page[huge], page_count(page), &page->flags);
ret = -EBUSY;
}
@@ -2786,7 +2789,7 @@ int soft_offline_page(unsigned long pfn, int flags)
mutex_lock(&mf_mutex);
if (PageHWPoison(page)) {
- pr_info("%s: %#lx page already poisoned\n", __func__, pfn);
+ pr_info("%#lx: page already poisoned\n", pfn);
put_ref_page(pfn, flags);
mutex_unlock(&mf_mutex);
return 0;
--
2.45.2.741.gdbec12cfda-goog
next prev parent reply other threads:[~2024-06-20 18:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 18:48 [PATCH v4 0/4] Userspace controls soft-offline pages Jiaqi Yan
2024-06-20 18:48 ` Jiaqi Yan [this message]
2024-06-24 3:08 ` [PATCH v4 1/4] mm/memory-failure: refactor log format in soft offline code Miaohe Lin
2024-06-20 18:48 ` [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages Jiaqi Yan
2024-06-24 3:41 ` Miaohe Lin
2024-06-24 16:18 ` Jiaqi Yan
2024-06-20 18:48 ` [PATCH v4 3/4] selftest/mm: test enable_soft_offline behaviors Jiaqi Yan
2024-06-21 5:08 ` Muhammad Usama Anjum
2024-06-21 14:43 ` Jiaqi Yan
2024-06-20 18:48 ` [PATCH v4 4/4] docs: mm: add enable_soft_offline sysctl Jiaqi Yan
2024-06-20 22:53 ` [PATCH v4 0/4] Userspace controls soft-offline pages Andi Kleen
2024-06-21 23:53 ` Jiaqi Yan
2024-06-22 16:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620184856.600717-2-jiaqiyan@google.com \
--to=jiaqiyan@google.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=duenwen@google.com \
--cc=fvdl@google.com \
--cc=jane.chu@oracle.com \
--cc=linmiaohe@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.