From: Jakub Kicinski <kuba@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"David S . Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Brett Creeley" <bcreeley@amd.com>,
"Ratheesh Kannoth" <rkannoth@marvell.com>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Tal Gilboa" <talgi@nvidia.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-doc@vger.kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Paul Greenwalt" <paul.greenwalt@intel.com>,
"Ahmed Zaki" <ahmed.zaki@intel.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Kory Maincent" <kory.maincent@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
justinstitt@google.com, donald.hunter@gmail.com,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dragos Tatulea" <dtatulea@nvidia.com>,
"Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"awel Dembicki" <paweldembicki@gmail.com>
Subject: Re: [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management
Date: Thu, 20 Jun 2024 20:39:18 -0700 [thread overview]
Message-ID: <20240620203918.407185c9@kernel.org> (raw)
In-Reply-To: <20240618025644.25754-4-hengqi@linux.alibaba.com>
On Tue, 18 Jun 2024 10:56:42 +0800 Heng Qi wrote:
> + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_RX) {
> + ret = ethnl_update_profile(dev, &dev->irq_moder->rx_profile,
> + tb[ETHTOOL_A_COALESCE_RX_PROFILE],
> + info->extack);
> + if (ret < 0)
> + return ret;
> + }
> +
> + if (dev->irq_moder && dev->irq_moder->profile_flags & DIM_PROFILE_TX) {
> + ret = ethnl_update_profile(dev, &dev->irq_moder->tx_profile,
> + tb[ETHTOOL_A_COALESCE_TX_PROFILE],
> + info->extack);
> + if (ret < 0)
> + return ret;
> + }
One last thing - you're missing updating the &mod bit.
When any of the settings were change mod should be set
to true so that we send a notification to user space,
that the settings have been modified.
next prev parent reply other threads:[~2024-06-21 3:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 2:56 [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-06-18 2:56 ` [PATCH RESEND net-next v14 1/5] linux/dim: move useful macros to .h file Heng Qi
2024-06-20 12:11 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 2/5] dim: make DIMLIB dependent on NET Heng Qi
2024-06-20 12:12 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-21 3:39 ` Jakub Kicinski [this message]
2024-06-21 6:28 ` Heng Qi
2024-06-21 3:44 ` Jakub Kicinski
2024-06-21 6:33 ` Heng Qi
2024-06-18 2:56 ` [PATCH RESEND net-next v14 4/5] dim: add new interfaces for initialization and getting results Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 5/5] virtio-net: support dim profile fine-tuning Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-21 3:40 ` [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel Jakub Kicinski
2024-06-21 3:44 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620203918.407185c9@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=hkallweit1@gmail.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=paweldembicki@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rkannoth@marvell.com \
--cc=rrameshbabu@nvidia.com \
--cc=talgi@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.