All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Chandan Babu R <chandan.babu@oracle.com>,
	Dave Chinner <david@fromorbit.com>,
	linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 04/11] xfs: background AIL push should target physical space
Date: Fri, 21 Jun 2024 07:37:26 +0200	[thread overview]
Message-ID: <20240621053726.GA15738@lst.de> (raw)
In-Reply-To: <20240620194226.GF103034@frogsfrogsfrogs>

On Thu, Jun 20, 2024 at 12:42:26PM -0700, Darrick J. Wong wrote:
> > transaction need to be pushed or re-logged to simply sample the
> > current target - they don't need to calculate the current target
> > themselves. This avoids the need for any locking when doing such
> > checks.
> 
> Ok, so I guess now the AIL kthread maintains the push target in
> ailp->ail_target all of the time?

Yes.

> I think this makes sense to me, but I'm wondering that I've never seen
> it on the list before.  This is a later revision to the earlier posting,
> right?

I started dusting off the last posted version and then Dave gave me
his latests working copy which hadn't been posted so far.

  reply	other threads:[~2024-06-21  5:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20  7:21 xfs: byte-based grant head reservation tracking v4 Christoph Hellwig
2024-06-20  7:21 ` [PATCH 01/11] xfs: fix the contact address for the sysfs ABI documentation Christoph Hellwig
2024-06-20 15:20   ` Darrick J. Wong
2024-06-20  7:21 ` [PATCH 02/11] xfs: move and rename xfs_trans_committed_bulk Christoph Hellwig
2024-06-20  7:21 ` [PATCH 03/11] xfs: AIL doesn't need manual pushing Christoph Hellwig
2024-06-20 19:01   ` Darrick J. Wong
2024-06-20  7:21 ` [PATCH 04/11] xfs: background AIL push should target physical space Christoph Hellwig
2024-06-20 19:42   ` Darrick J. Wong
2024-06-21  5:37     ` Christoph Hellwig [this message]
2024-06-21 16:18       ` Darrick J. Wong
2024-06-20  7:21 ` [PATCH 05/11] xfs: ensure log tail is always up to date Christoph Hellwig
2024-06-20  7:21 ` [PATCH 06/11] xfs: l_last_sync_lsn is really AIL state Christoph Hellwig
2024-06-20  7:21 ` [PATCH 07/11] xfs: collapse xlog_state_set_callback in caller Christoph Hellwig
2024-06-20  7:21 ` [PATCH 08/11] xfs: track log space pinned by the AIL Christoph Hellwig
2024-06-20  7:21 ` [PATCH 09/11] xfs: pass the full grant head to accounting functions Christoph Hellwig
2024-06-20  7:21 ` [PATCH 10/11] xfs: grant heads track byte counts, not LSNs Christoph Hellwig
2024-07-01  0:59   ` Dave Chinner
2024-06-20  7:21 ` [PATCH 11/11] xfs: skip flushing log items during push Christoph Hellwig
2024-06-20 19:51   ` Darrick J. Wong
2024-06-21  5:48     ` Christoph Hellwig
2024-06-21 17:46       ` Darrick J. Wong
2024-07-02 18:51         ` Darrick J. Wong
2024-07-02 23:29           ` Dave Chinner
2024-07-03  5:10             ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621053726.GA15738@lst.de \
    --to=hch@lst.de \
    --cc=chandan.babu@oracle.com \
    --cc=david@fromorbit.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.