All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil V L <sunilvl@ventanamicro.com>
To: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Ani Sinha" <anisinha@redhat.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Sia Jee Heng" <jeeheng.sia@starfivetech.com>,
	"Alistair Francis" <alistair23@gmail.com>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Sunil V L" <sunilvl@ventanamicro.com>
Subject: [PATCH v3 05/15] tests/qtest/bios-tables-test.c: Add support for arch in path
Date: Fri, 21 Jun 2024 17:28:56 +0530	[thread overview]
Message-ID: <20240621115906.1049832-6-sunilvl@ventanamicro.com> (raw)
In-Reply-To: <20240621115906.1049832-1-sunilvl@ventanamicro.com>

Since machine name can be common for multiple architectures (ex: virt),
add "arch" in the path to search for expected AML files. Since the AML
files are still under old path, add support for searching with and
without arch in the path.

Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
 tests/qtest/bios-tables-test.c | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index c4a4d1c7bf..29c52952f4 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -78,6 +78,7 @@
 typedef struct {
     bool tcg_only;
     const char *machine;
+    const char *arch;
     const char *machine_param;
     const char *variant;
     const char *uefi_fl1;
@@ -262,8 +263,19 @@ static void dump_aml_files(test_data *data, bool rebuild)
         g_assert(exp_sdt->aml);
 
         if (rebuild) {
-            aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir, data->machine,
+            aml_file = g_strdup_printf("%s/%s/%s/%.4s%s", data_dir,
+                                       data->arch, data->machine,
                                        sdt->aml, ext);
+
+            /*
+             * To keep test cases not failing before the DATA files are moved to
+             * ${arch}/${machine} folder, add this check as well.
+             */
+            if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
+                aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir,
+                                           data->machine, sdt->aml, ext);
+            }
+
             if (!g_file_test(aml_file, G_FILE_TEST_EXISTS) &&
                 sdt->aml_len == exp_sdt->aml_len &&
                 !memcmp(sdt->aml, exp_sdt->aml, sdt->aml_len)) {
@@ -398,8 +410,13 @@ static GArray *load_expected_aml(test_data *data)
         memset(&exp_sdt, 0, sizeof(exp_sdt));
 
 try_again:
-        aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir, data->machine,
-                                   sdt->aml, ext);
+        aml_file = g_strdup_printf("%s/%s/%s/%.4s%s", data_dir, data->arch,
+                                   data->machine, sdt->aml, ext);
+        if (!g_file_test(aml_file, G_FILE_TEST_EXISTS)) {
+            aml_file = g_strdup_printf("%s/%s/%.4s%s", data_dir, data->machine,
+                                       sdt->aml, ext);
+        }
+
         if (verbosity_level >= 2) {
             fprintf(stderr, "Looking for expected file '%s'\n", aml_file);
         }
-- 
2.40.1



  parent reply	other threads:[~2024-06-21 11:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 11:58 [PATCH v3 00/15] Add support for RISC-V ACPI tests Sunil V L
2024-06-21 11:58 ` [PATCH v3 01/15] uefi-test-tools/UefiTestToolsPkg: Add RISC-V support Sunil V L
2024-06-25  8:42   ` Igor Mammedov
2024-06-21 11:58 ` [PATCH v3 02/15] uefi-test-tools: Add support for python based build script Sunil V L
2024-06-24  8:04   ` Gerd Hoffmann
2024-06-25  8:42   ` Igor Mammedov
2024-06-21 11:58 ` [PATCH v3 03/15] tests/data/uefi-boot-images: Add RISC-V ISO image Sunil V L
2024-06-21 11:58 ` [PATCH v3 04/15] qtest: bios-tables-test: Rename aarch64 tests with aarch64 in them Sunil V L
2024-06-21 11:58 ` Sunil V L [this message]
2024-06-24  6:03   ` [PATCH v3 05/15] tests/qtest/bios-tables-test.c: Add support for arch in path Alistair Francis
2024-06-25 10:48   ` Igor Mammedov
2024-06-21 11:58 ` [PATCH v3 06/15] tests/qtest/bios-tables-test.c: Set "arch" for aarch64 tests Sunil V L
2024-06-24  6:04   ` Alistair Francis
2024-06-25 10:48   ` Igor Mammedov
2024-06-21 11:58 ` [PATCH v3 07/15] tests/qtest/bios-tables-test.c: Set "arch" for x86 tests Sunil V L
2024-06-25 10:49   ` Igor Mammedov
2024-06-21 11:58 ` [PATCH v3 08/15] tests/data/acpi: Move x86 ACPI tables under x86/${machine} path Sunil V L
2024-06-25 10:49   ` Igor Mammedov
2024-06-21 11:59 ` [PATCH v3 09/15] tests/data/acpi/virt: Move ARM64 ACPI tables under aarch64/${machine} path Sunil V L
2024-06-25 10:49   ` Igor Mammedov
2024-06-21 11:59 ` [PATCH v3 10/15] meson.build: Add RISC-V to the edk2-target list Sunil V L
2024-06-21 11:59 ` [PATCH v3 11/15] pc-bios/meson.build: Add support for RISC-V in unpack_edk2_blobs Sunil V L
2024-06-21 11:59 ` [PATCH v3 12/15] tests/data/acpi/rebuild-expected-aml.sh: Add RISC-V Sunil V L
2024-06-21 11:59 ` [PATCH v3 13/15] tests/qtest/bios-tables-test: Add empty ACPI data files for RISC-V Sunil V L
2024-06-21 11:59 ` [PATCH v3 14/15] tests/qtest/bios-tables-test.c: Enable basic testing " Sunil V L
2024-06-25 11:19   ` Igor Mammedov
2024-06-25 12:05     ` Igor Mammedov
2024-06-25 12:29       ` Sunil V L
2024-06-25 14:06         ` Igor Mammedov
2024-06-25 15:18           ` Sunil V L
2024-06-21 11:59 ` [PATCH v3 15/15] tests/qtest/bios-tables-test: Add expected ACPI data files " Sunil V L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621115906.1049832-6-sunilvl@ventanamicro.com \
    --to=sunilvl@ventanamicro.com \
    --cc=alistair23@gmail.com \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=imammedo@redhat.com \
    --cc=jeeheng.sia@starfivetech.com \
    --cc=kraxel@redhat.com \
    --cc=liwei1518@gmail.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.