Re: [PATCH v2 -qemu] hw/cxl: Support firmware updates

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Fri, 21 Jun 2024 17:58:18 +0100
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:

> On Tue, 19 Mar 2024 13:48:18 -0700
> Davidlohr Bueso <dave@stgolabs.net> wrote:
> 
> > On Tue, 19 Mar 2024, fan wrote:
> >   
> > >> +/* CXL r3.1 section 8.2.9.3.2: Transfer FW (Opcode 0201h) */
> > >> +#define CXL_FW_XFER_ALIGNMENT   128
> > >> +
> > >> +#define CXL_FW_XFER_ACTION_FULL	    0x0
> > >> +#define CXL_FW_XFER_ACTION_INIT	    0x1
> > >> +#define CXL_FW_XFER_ACTION_CONTINUE 0x2
> > >> +#define CXL_FW_XFER_ACTION_END	    0x3
> > >> +#define CXL_FW_XFER_ACTION_ABORT    0x4    
> > >
> > >The above definitions have "tab" used, cannot pass checkpatch check.    
> > 
> > I was not aware of a checkpatch for qemu, will clean up.
> >   
> > >> +
> > >> +static CXLRetCode cmd_firmware_update_transfer(const struct cxl_cmd *cmd,
> > >> +                                               uint8_t *payload_in,
> > >> +                                               size_t len,
> > >> +                                               uint8_t *payload_out,
> > >> +                                               size_t *len_out,
> > >> +                                               CXLCCI *cci)
> > >> +{
> > >> +    struct {
> > >> +        uint8_t action;
> > >> +        uint8_t slot;
> > >> +        uint8_t caps;    
> > >
> > >Based on table 8-66, I cannot find the field "caps" and it is unused.    
> > 
> > Hmm yep don't know how that snuck in, will get rid of it.
> > 
> > Thanks,
> > Davidlohr  
> 
> I fixed both on my tree.
> 

Then dropped it when reading Davidlohr's reply and seeing there was more to do.
Looking forward to v3 :)

Jonathan