From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<brett.creeley@amd.com>, <drivers@pensando.io>
Subject: Re: [PATCH v2 net] ionic: use dev_consume_skb_any outside of napi
Date: Fri, 21 Jun 2024 18:21:28 -0700 [thread overview]
Message-ID: <20240621182128.3a9481ce@kernel.org> (raw)
In-Reply-To: <20240620192519.35395-1-shannon.nelson@amd.com>
On Thu, 20 Jun 2024 12:25:19 -0700 Shannon Nelson wrote:
> - work_done = ionic_tx_cq_service(cq, budget);
> + work_done = ionic_tx_cq_service(cq, budget, true);
you gotta use budget. When budget is 0 you're in netpoll not in real
NAPI. So you can keep the bool but instead of unconditionally passing
true you gotta pass !!budget.
--
pw-bot: cr
prev parent reply other threads:[~2024-06-22 1:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 19:25 [PATCH v2 net] ionic: use dev_consume_skb_any outside of napi Shannon Nelson
2024-06-22 1:21 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621182128.3a9481ce@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.