From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAF42186E5F; Sun, 23 Jun 2024 13:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719150274; cv=none; b=DRdA7f4LiH0Jv57V+ylLkwmHDhNHjbg5RyFs1VY5/4wgE/DPAdbxyMAYFbexWx71Y+vcy5wRUxlnk1auoIVSwhHZ+yu+99LHpKMJY59RGmBBX+Jf8vi/TmWlrke4DXZAFoc3XWO6KKcfhlg7xj8JEAfg629GyDJnwbrGq4vpxxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719150274; c=relaxed/simple; bh=rUCTeHFEsTNoBfriDV9qQ9XKyU1KQDUpP5agkA7ksbE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CeTxik4UEOsZLC/V7ly15XFBSnerePr1hgPL03ISyMQ3s0a82jeGFuM9WqSEbax/HAZLfjyvOmDaTFrkCVEiQvn0oNA84v0UDsFHytF5iCNZdGaknaqhspRier7RX54dsaM/GUGdcUmHip9YMa2zyZsoMGIzokgTxwXwJYo7B5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sRm7Aejc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sRm7Aejc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CED6CC32781; Sun, 23 Jun 2024 13:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719150273; bh=rUCTeHFEsTNoBfriDV9qQ9XKyU1KQDUpP5agkA7ksbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sRm7Aejcyb55bMYCPm+enZPJw7pXUnEIfjSK8PVtATUcLR9ZznUNo4EuyL9fF4non UWd5jTQvc7G+vimmfIvlTpCGXcQEZXf6nBHbKx/8dVpX2JLuhpwJMGVpuyz59u67bO AxkaouX4CIcx3/g2X1iSUaho/uDoppX5YMfFOdDLm56J/FrG/k5MK+0ZNqqpD03Hlu I/0giaOPMvPNbQ3io0Z3lPwjN5610ySy+oL9diBf2fzN8WtYj3xoZehFohtRpqr3pj LrP0Y5ElW77e037Nx/HZklEb4/XUiW4qIWXTuoyN30CmM0gvUkcNHpIKpLq6WtrOBn f2fKTMDV5Jm5Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Douglas Anderson , Maxime Ripard , Geert Uytterhoeven , Laurent Pinchart , Sui Jingfeng , Sasha Levin , maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: [PATCH AUTOSEL 6.9 16/21] drm: renesas: shmobile: Call drm_atomic_helper_shutdown() at shutdown time Date: Sun, 23 Jun 2024 09:43:49 -0400 Message-ID: <20240623134405.809025-16-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623134405.809025-1-sashal@kernel.org> References: <20240623134405.809025-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.9.6 Content-Transfer-Encoding: 8bit From: Douglas Anderson [ Upstream commit 0320ca14c6fb68ad19aa72e55a1a21c061b2946b ] Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. This is important because drm_atomic_helper_shutdown() will cause panels to get disabled cleanly which may be important for their power sequencing. Future changes will remove any custom powering off in individual panel drivers so the DRM drivers need to start getting this right. The fact that we should call drm_atomic_helper_shutdown() in the case of OS shutdown comes straight out of the kernel doc "driver instance overview" in drm_drv.c. [geert: shmob_drm_remove() already calls drm_atomic_helper_shutdown] Suggested-by: Maxime Ripard Signed-off-by: Douglas Anderson Link: https://lore.kernel.org/r/20230901164111.RFT.15.Iaf638a1d4c8b3c307a6192efabb4cbb06b195f15@changeid [geert: s/drm_helper_force_disable_all/drm_atomic_helper_shutdown/] Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Reviewed-by: Sui Jingfeng Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/17c6a5a668e5975f871b77fb1fca6711a0799d9e.1718176895.git.geert+renesas@glider.be Signed-off-by: Sasha Levin --- drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c index e83c3e52251de..0250d5f00bf10 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c @@ -171,6 +171,13 @@ static void shmob_drm_remove(struct platform_device *pdev) drm_kms_helper_poll_fini(ddev); } +static void shmob_drm_shutdown(struct platform_device *pdev) +{ + struct shmob_drm_device *sdev = platform_get_drvdata(pdev); + + drm_atomic_helper_shutdown(&sdev->ddev); +} + static int shmob_drm_probe(struct platform_device *pdev) { struct shmob_drm_platform_data *pdata = pdev->dev.platform_data; @@ -273,6 +280,7 @@ static const struct of_device_id shmob_drm_of_table[] __maybe_unused = { static struct platform_driver shmob_drm_platform_driver = { .probe = shmob_drm_probe, .remove_new = shmob_drm_remove, + .shutdown = shmob_drm_shutdown, .driver = { .name = "shmob-drm", .of_match_table = of_match_ptr(shmob_drm_of_table), -- 2.43.0