From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30661C2BBCA for ; Sun, 23 Jun 2024 13:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:To:From:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7lTTD8KPV543PLRJ1YfZReWkqcQFgefvm1JO7l/TpBw=; b=vYRlHqhjh8ZtYm L1k1NZLsh8Vc5Bc7jzPUyP51RG6dZ1o13/cLc16RhF8d+XF1pCvhE+TlysMJGi6btgPsLBbQb2y+K +XqHrjBGmu3TaR8tLk5VGuy4xvbu3QNWkxZ6xl46/P2INoKXTHLhLLpCbnWL8xHd4489z6VIzsrtD pUECnp6Q9MyZx1oVafpAc6pYheNticxl5wtnY/y9FXAtR6fmd3EgFZ99p0162aEPKpvCvrEHuJGpf 6C/p0ryK1Gu/jY29EaVn3H7qLe+pSw9b4a1SrS4yrFYX0vHmElu63w3jR9ViyD/oLQKr4dfVkDBLH Z48cdudMpKXHluZLcIpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLNWU-0000000E5KU-02Fy; Sun, 23 Jun 2024 13:44:50 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLNWJ-0000000E5CT-0kAt; Sun, 23 Jun 2024 13:44:41 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 77B59CE0EB3; Sun, 23 Jun 2024 13:44:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C383BC4AF0A; Sun, 23 Jun 2024 13:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719150275; bh=1iEt7pWGYS2hyN5GpFzmy5TaSS/4n7EjJ6M5ocC9fBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ERvrcfIBKr2hjPW6yvLt1ujHozicSc7NQRJn2fMaHK1EmtGaR49Euwh+nFpXNnP0k 7nSfGpwO4bu01BPwW+RYOApXpoYJ9q8OJu/P+GZ49WOGeBCet7xGsNS9LpXrXQl+nK bbkiCxgjtHvqaBoM5/TICsgBZGu3Rsb0AaXLv88cJ8VrBHik4TsGmCBYwJAjpjud/m G1javHZUXHcKkxJPrkSCiYUwZPOfzYPjjCG0l+Iy+B9Nhi3+QBWGZ0OGO1/oEZHnb6 9SPl7JOwm805gU+ZRWs59y5tonBXzsB+0NbAoL1ar9RwpDWq7pObtQdELt/gnNPhRC jYfmMXK4/Rf5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH AUTOSEL 6.9 17/21] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Date: Sun, 23 Jun 2024 09:43:50 -0400 Message-ID: <20240623134405.809025-17-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623134405.809025-1-sashal@kernel.org> References: <20240623134405.809025-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.9.6 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240623_064439_616546_FC9348D7 X-CRM114-Status: GOOD ( 16.39 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , chunkuang.hu@kernel.org, daniel@ffwll.ch, Douglas Anderson , Maxime Ripard , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, p.zabel@pengutronix.de, matthias.bgg@gmail.com, airlied@gmail.com, linux-arm-kernel@lists.infradead.org, angelogioacchino.delregno@collabora.com Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org From: Douglas Anderson [ Upstream commit c38896ca6318c2df20bbe6c8e3f633e071fda910 ] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic_helper_shutdown() in the case of OS shutdown/restart comes straight out of the kernel doc "driver instance overview" in drm_drv.c. This driver users the component model and shutdown happens in the base driver. The "drvdata" for this driver will always be valid if shutdown() is called and as of commit 2a073968289d ("drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a noop") we don't need to confirm that "drm" is non-NULL. Suggested-by: Maxime Ripard Reviewed-by: Maxime Ripard Reviewed-by: Fei Shao Tested-by: Fei Shao Signed-off-by: Douglas Anderson Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20240611102744.v2.1.I2b014f90afc4729b6ecc7b5ddd1f6dedcea4625b@changeid Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 74832c2130921..0b570e194079a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -950,6 +950,13 @@ static void mtk_drm_remove(struct platform_device *pdev) of_node_put(private->comp_node[i]); } +static void mtk_drm_shutdown(struct platform_device *pdev) +{ + struct mtk_drm_private *private = platform_get_drvdata(pdev); + + drm_atomic_helper_shutdown(private->drm); +} + static int mtk_drm_sys_prepare(struct device *dev) { struct mtk_drm_private *private = dev_get_drvdata(dev); @@ -981,6 +988,7 @@ static const struct dev_pm_ops mtk_drm_pm_ops = { static struct platform_driver mtk_drm_platform_driver = { .probe = mtk_drm_probe, .remove_new = mtk_drm_remove, + .shutdown = mtk_drm_shutdown, .driver = { .name = "mediatek-drm", .pm = &mtk_drm_pm_ops, -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA23E18734B; Sun, 23 Jun 2024 13:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719150275; cv=none; b=IyFGS4a9+Dro9Plu1z1LoaU2bq+Oz5HwjI2iHWzc0wc4inBaqHwkaKkx2OhKCVF/UlAlD01LRI3yjncNKbVR48NJXWWySMsaMh9Ue+VYJNEm6YY6Y7fQ3RWiLaQvFKxNsmLNpCOUi1AdmQuSBepdGUlK+JmaEUQ5bpU8PGP+Mik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719150275; c=relaxed/simple; bh=1iEt7pWGYS2hyN5GpFzmy5TaSS/4n7EjJ6M5ocC9fBM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ubgN8fMh618pfcEkzMwXWELGK6UgSpIuwJba9EFbEVIz7bFqD2ZQRCF+wR3IKqKimHpWJMt5C8In+1pwpgjAyefZuCSc6umdADtf27z+EmS0YItcCs1F2Z/xBQqRbwDFZQ+RtBaTy1TUV4ZLEU7r66Bff/Zps0cdexUqQmAM3h8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ERvrcfIB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ERvrcfIB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C383BC4AF0A; Sun, 23 Jun 2024 13:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719150275; bh=1iEt7pWGYS2hyN5GpFzmy5TaSS/4n7EjJ6M5ocC9fBM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ERvrcfIBKr2hjPW6yvLt1ujHozicSc7NQRJn2fMaHK1EmtGaR49Euwh+nFpXNnP0k 7nSfGpwO4bu01BPwW+RYOApXpoYJ9q8OJu/P+GZ49WOGeBCet7xGsNS9LpXrXQl+nK bbkiCxgjtHvqaBoM5/TICsgBZGu3Rsb0AaXLv88cJ8VrBHik4TsGmCBYwJAjpjud/m G1javHZUXHcKkxJPrkSCiYUwZPOfzYPjjCG0l+Iy+B9Nhi3+QBWGZ0OGO1/oEZHnb6 9SPl7JOwm805gU+ZRWs59y5tonBXzsB+0NbAoL1ar9RwpDWq7pObtQdELt/gnNPhRC jYfmMXK4/Rf5w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Douglas Anderson , Maxime Ripard , Fei Shao , Sasha Levin , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.9 17/21] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Date: Sun, 23 Jun 2024 09:43:50 -0400 Message-ID: <20240623134405.809025-17-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240623134405.809025-1-sashal@kernel.org> References: <20240623134405.809025-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.9.6 Content-Transfer-Encoding: 8bit From: Douglas Anderson [ Upstream commit c38896ca6318c2df20bbe6c8e3f633e071fda910 ] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic_helper_shutdown() in the case of OS shutdown/restart comes straight out of the kernel doc "driver instance overview" in drm_drv.c. This driver users the component model and shutdown happens in the base driver. The "drvdata" for this driver will always be valid if shutdown() is called and as of commit 2a073968289d ("drm/atomic-helper: drm_atomic_helper_shutdown(NULL) should be a noop") we don't need to confirm that "drm" is non-NULL. Suggested-by: Maxime Ripard Reviewed-by: Maxime Ripard Reviewed-by: Fei Shao Tested-by: Fei Shao Signed-off-by: Douglas Anderson Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20240611102744.v2.1.I2b014f90afc4729b6ecc7b5ddd1f6dedcea4625b@changeid Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 74832c2130921..0b570e194079a 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -950,6 +950,13 @@ static void mtk_drm_remove(struct platform_device *pdev) of_node_put(private->comp_node[i]); } +static void mtk_drm_shutdown(struct platform_device *pdev) +{ + struct mtk_drm_private *private = platform_get_drvdata(pdev); + + drm_atomic_helper_shutdown(private->drm); +} + static int mtk_drm_sys_prepare(struct device *dev) { struct mtk_drm_private *private = dev_get_drvdata(dev); @@ -981,6 +988,7 @@ static const struct dev_pm_ops mtk_drm_pm_ops = { static struct platform_driver mtk_drm_platform_driver = { .probe = mtk_drm_probe, .remove_new = mtk_drm_remove, + .shutdown = mtk_drm_shutdown, .driver = { .name = "mediatek-drm", .pm = &mtk_drm_pm_ops, -- 2.43.0