From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbecker@suse.com>,
Mel Gorman <mgorman@suse.de>, Hannes Reinecke <hare@suse.de>,
Sridhar Balaraman <sbalaraman@parallelwireless.com>,
"brookxu.cn" <brookxu.cn@gmail.com>,
Ming Lei <ming.lei@redhat.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/3] sched/isolation: Add io_queue housekeeping option
Date: Mon, 24 Jun 2024 10:47:05 +0200 [thread overview]
Message-ID: <20240624084705.GA20292@lst.de> (raw)
In-Reply-To: <x2mjbnluozxykdtqns47f37ssdkziovkdzchon5zkcadgkuuif@qloym5wjwomm>
On Mon, Jun 24, 2024 at 09:13:06AM +0200, Daniel Wagner wrote:
> On Sat, Jun 22, 2024 at 07:11:57AM GMT, Christoph Hellwig wrote:
> > > diff --git a/include/linux/sched/isolation.h b/include/linux/sched/isolation.h
> > > index 2b461129d1fa..fe751d704e99 100644
> > > --- a/include/linux/sched/isolation.h
> > > +++ b/include/linux/sched/isolation.h
> > > @@ -16,6 +16,7 @@ enum hk_type {
> > > HK_TYPE_WQ,
> > > HK_TYPE_MANAGED_IRQ,
> > > HK_TYPE_KTHREAD,
> > > + HK_TYPE_IO_QUEUE,
> > > HK_TYPE_MAX
> > > };
> >
> > It might be a good time to write comments explaining these types?
>
> Sure, will do.
>
> Do you think we should introduce a new type or just use the existing
> managed_irq for this?
No idea really. What was the reason for adding a new one? The best
person to comment on this is probably Thomas.
next prev parent reply other threads:[~2024-06-24 8:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 13:53 [PATCH 0/3] nvme-pci: honor isolcpus configuration Daniel Wagner
2024-06-21 13:53 ` [PATCH 1/3] sched/isolation: Add io_queue housekeeping option Daniel Wagner
2024-06-22 5:11 ` Christoph Hellwig
2024-06-24 7:13 ` Daniel Wagner
2024-06-24 8:47 ` Christoph Hellwig [this message]
2024-06-24 9:00 ` Daniel Wagner
2024-06-25 6:37 ` Hannes Reinecke
2024-06-25 7:07 ` Thomas Gleixner
2024-06-25 8:57 ` Daniel Wagner
2024-06-30 13:47 ` Ming Lei
2024-06-21 13:53 ` [PATCH 2/3] nvme-pci: limit queue count to housekeeping cpus Daniel Wagner
2024-06-22 5:14 ` Christoph Hellwig
2024-06-23 7:03 ` Sagi Grimberg
2024-06-21 13:53 ` [PATCH 3/3] lib/group_cpus.c: honor housekeeping config when grouping CPUs Daniel Wagner
2024-06-22 5:13 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624084705.GA20292@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=dwagner@suse.de \
--cc=fweisbecker@suse.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mgorman@suse.de \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=sbalaraman@parallelwireless.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.