From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next 4/4] selftests: drv-net: rss_ctx: add tests for RSS configuration and contexts
Date: Mon, 24 Jun 2024 09:02:06 -0700 [thread overview]
Message-ID: <20240624090206.5585c2b6@kernel.org> (raw)
In-Reply-To: <20240624075035.037041e3@kernel.org>
On Mon, 24 Jun 2024 07:50:35 -0700 Jakub Kicinski wrote:
> > > + key_len = len(data['rss-hash-key'])
> > > +
> > > + # Set the key
> > > + key = _rss_key_rand(key_len)
> > > + ethtool(f"-X {cfg.ifname} hkey " + _rss_key_str(key))
> >
> > Probably too paranoid, but in case failure is only for some randomized
> > input, is the key logged on error?
>
> Will add!
I take that back, if ethtool() -> tool() -> cmd() fails we'll throw
and exception which already includes the command as well as stdout
and stderr. So we'll see in the logs what the key was.
next prev parent reply other threads:[~2024-06-24 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 23:28 [PATCH net-next 0/4] selftests: drv-net: rss_ctx: add tests for RSS contexts Jakub Kicinski
2024-06-20 23:28 ` [PATCH net-next 1/4] selftests: drv-net: try to check if port is in use Jakub Kicinski
2024-06-21 1:52 ` David Wei
2024-06-23 7:34 ` Willem de Bruijn
2024-06-24 13:59 ` Przemek Kitszel
2024-06-20 23:28 ` [PATCH net-next 2/4] selftests: drv-net: add helper to wait for HW stats to sync Jakub Kicinski
2024-06-23 7:37 ` Willem de Bruijn
2024-06-24 14:43 ` Jakub Kicinski
2024-06-20 23:29 ` [PATCH net-next 3/4] selftests: drv-net: add ability to wait for at least N packets to load gen Jakub Kicinski
2024-06-21 1:14 ` David Wei
2024-06-20 23:29 ` [PATCH net-next 4/4] selftests: drv-net: rss_ctx: add tests for RSS configuration and contexts Jakub Kicinski
2024-06-21 1:52 ` David Wei
2024-06-21 2:26 ` Jakub Kicinski
2024-06-23 8:03 ` Willem de Bruijn
2024-06-24 14:50 ` Jakub Kicinski
2024-06-24 16:02 ` Jakub Kicinski [this message]
2024-06-24 12:55 ` Edward Cree
2024-06-24 14:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624090206.5585c2b6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.