From: Lee Jones <lee@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback
Date: Mon, 24 Jun 2024 11:46:51 +0100 [thread overview]
Message-ID: <20240624104651.GO1318296@google.com> (raw)
In-Reply-To: <CAMuHMdVdTusWYK0cD_Ez5bv21iKVF2MOT24+_VR+94W3iqDK5A@mail.gmail.com>
On Mon, 24 Jun 2024, Geert Uytterhoeven wrote:
> Hi Lee,
>
> On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote:
> > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:
> > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > include/linux/mfd/tmio.h | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> > > --- a/include/linux/mfd/tmio.h
> > > +++ b/include/linux/mfd/tmio.h
> > > @@ -101,7 +101,6 @@ struct tmio_mmc_data {
> > > unsigned int max_blk_count;
> > > unsigned short max_segs;
> > > void (*set_pwr)(struct platform_device *host, int state);
> > > - void (*set_clk_div)(struct platform_device *host, int state);
> >
> > Any ramifications for just hoovering this up?
>
> I am sorry, I am not familiar with that expression.
> Can you please elaborate?
> Thanks!
If I take _only_ this patch and leave the MMC one, will something break?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-06-24 10:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 15:39 [PATCH 0/2] mmc: tmio: Remove obsolete callbacks Geert Uytterhoeven
2024-06-20 15:39 ` [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback Geert Uytterhoeven
2024-06-20 17:08 ` Lee Jones
2024-06-24 9:05 ` Geert Uytterhoeven
2024-06-24 10:46 ` Lee Jones [this message]
2024-06-24 11:42 ` Geert Uytterhoeven
2024-06-24 12:55 ` Lee Jones
2024-06-20 20:05 ` Wolfram Sang
2024-06-21 8:56 ` Wolfram Sang
2024-06-21 9:00 ` Lad, Prabhakar
2024-06-20 15:39 ` [PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback() Geert Uytterhoeven
2024-06-20 17:07 ` Lee Jones
2024-06-20 20:09 ` Wolfram Sang
2024-06-21 8:56 ` Wolfram Sang
2024-06-21 9:01 ` Lad, Prabhakar
2024-06-24 14:55 ` [PATCH 0/2] mmc: tmio: Remove obsolete callbacks Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624104651.GO1318296@google.com \
--to=lee@kernel.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.