Re: [meta-ti] [RFC][master/scarthgap][PATCH 1/4] cc33conf: add new cc33conf tool for cc33xx devices

[Denys Dmytriyenko <denis@denix.org>]

On Thu, Jun 20, 2024 at 03:40:22PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote:
> 
> On 6/20/2024 3:20 PM, Denys Dmytriyenko wrote:
> >On Wed, Jun 19, 2024 at 10:21:59PM -0500, Sabeeh Khan via lists.yoctoproject.org wrote:
> >>cc33conf is a tool provided by TI to configure
> >>cc33xx WLAN devices. It can be used to change
> >>the RF parameters and other features of the target.
> >>Documentation for this tool is provided within the following link:
> >>https://www.ti.com/tool/CC33XX-SOFTWARE
> >>
> >>Signed-off-by: Sabeeh Khan<sabeeh-khan@ti.com>
> >>---
> >>  .../cc33conf/cc33conf_git.bb                  | 29 +++++++++++++++++++
> >>  1 file changed, 29 insertions(+)
> >>  create mode 100644 meta-ti-extras/recipes-connectivity/cc33conf/cc33conf_git.bb
> >>
> >>diff --git a/meta-ti-extras/recipes-connectivity/cc33conf/cc33conf_git.bb b/meta-ti-extras/recipes-connectivity/cc33conf/cc33conf_git.bb
> >>new file mode 100644
> >>index 00000000..1e4faa77
> >>--- /dev/null
> >>+++ b/meta-ti-extras/recipes-connectivity/cc33conf/cc33conf_git.bb
> >>@@ -0,0 +1,29 @@
> >>+DESCRIPTION = "Configuration utility for TI CC33xx wireless devices"
> >>+LICENSE = "BSD-3-Clause"
> >>+LIC_FILES_CHKSUM ="file://COPYING;md5=d5fc448a36efe573623542dcb989afc4"
> >>+
> >>+SRCREV = "a2f84140b8d67cfc94472cf92676a409d1e47d86"
> >>+SRC_URI = "git://git.ti.com/git/cc33xx-wlan/cc33xx-utils.git;branch=master;protocol=https"
> >>+
> >>+PV = "1.7.0.120"
> >>+
> >>+S = "${WORKDIR}/git/cc33conf"
> >>+
> >>+EXTRA_OEMAKE = "CC="${CC}""
> >>+
> >>+do_install() {
> >>+	install -d ${D}${sbindir}
> >>+	install -d ${D}${sbindir}/cc33conf/
> >>+
> >>+	install -m 0755 cc33xxconf ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 dictionary.txt ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 default.conf ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 README ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 cc33xx-conf.conf ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 cc33xx-conf.ini ${D}${sbindir}/cc33conf/
> >>+	install -m 0755 conf.h ${D}${sbindir}/cc33conf/
> >Should all these files really go into sbindir?
> 
> This recipe and tool is based off of wlconf. Since wlconf was
> already accepted,
> 
> I figured installing to a similar location would be practical.
> 
> However, I am open to other locations if you have suggestions.
> 
> The tool does use all of these files.

Well, wlconf does indeed set a bad precedent...

Are those files being used relative to the binary and hence should reside 
there?

The standard is to have conf files in /etc, binaries in /usr/bin or /bin, 
docs/READMEs in /usr/share/doc and .h headers in /usr/include.

And bitbake.conf sets all the corresponding variables accordingly, such as 
sysconfdir, bindir, datadir, docdir, includedir, etc:
https://git.openembedded.org/openembedded-core/tree/meta/conf/bitbake.conf

So, if the tool is capable of locating its files in the proper system-wide 
locations, the recipe should definitely install them in the right location.

-- 
Denys