From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
willemdebruijn.kernel@gmail.com, ecree.xilinx@gmail.com,
dw@davidwei.uk, przemyslaw.kitszel@intel.com,
michael.chan@broadcom.com, andrew.gospodarek@broadcom.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v2 2/4] selftests: drv-net: add helper to wait for HW stats to sync
Date: Mon, 24 Jun 2024 18:02:08 -0700 [thread overview]
Message-ID: <20240625010210.2002310-3-kuba@kernel.org> (raw)
In-Reply-To: <20240625010210.2002310-1-kuba@kernel.org>
Some devices DMA stats to the host periodically. Add a helper
which can wait for that to happen, based on frequency reported
by the driver in ethtool.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
v2:
- sleep for 25ms on top of the driver DMA period
(and remove confusing comment)
---
.../selftests/drivers/net/lib/py/env.py | 20 ++++++++++++++++++-
tools/testing/selftests/net/lib/py/utils.py | 4 ++++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/lib/py/env.py b/tools/testing/selftests/drivers/net/lib/py/env.py
index edcedd7bffab..16d24fe7107d 100644
--- a/tools/testing/selftests/drivers/net/lib/py/env.py
+++ b/tools/testing/selftests/drivers/net/lib/py/env.py
@@ -1,9 +1,10 @@
# SPDX-License-Identifier: GPL-2.0
import os
+import time
from pathlib import Path
from lib.py import KsftSkipEx, KsftXfailEx
-from lib.py import cmd, ip
+from lib.py import cmd, ethtool, ip
from lib.py import NetNS, NetdevSimDev
from .remote import Remote
@@ -82,6 +83,8 @@ from .remote import Remote
self.env = _load_env_file(src_path)
+ self._stats_settle_time = None
+
# Things we try to destroy
self.remote = None
# These are for local testing state
@@ -222,3 +225,18 @@ from .remote import Remote
if remote:
if not self._require_cmd(comm, "remote"):
raise KsftSkipEx("Test requires (remote) command: " + comm)
+
+ def wait_hw_stats_settle(self):
+ """
+ Wait for HW stats to become consistent, some devices DMA HW stats
+ periodically so events won't be reflected until next sync.
+ Good drivers will tell us via ethtool what their sync period is.
+ """
+ if self._stats_settle_time is None:
+ self._stats_settle_time = 0.025
+
+ data = ethtool("-c " + self.ifname, json=True)[0]
+ if 'stats-block-usecs' in data:
+ self._stats_settle_time += data['stats-block-usecs'] / 1000 / 1000
+
+ time.sleep(self._stats_settle_time)
diff --git a/tools/testing/selftests/net/lib/py/utils.py b/tools/testing/selftests/net/lib/py/utils.py
index 16907b51e034..11dbdd3b7612 100644
--- a/tools/testing/selftests/net/lib/py/utils.py
+++ b/tools/testing/selftests/net/lib/py/utils.py
@@ -78,6 +78,10 @@ import time
return tool('ip', args, json=json, host=host)
+def ethtool(args, json=None, ns=None, host=None):
+ return tool('ethtool', args, json=json, ns=ns, host=host)
+
+
def rand_port():
"""
Get a random unprivileged port, try to make sure it's not already used.
--
2.45.2
next prev parent reply other threads:[~2024-06-25 1:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 1:02 [PATCH net-next v2 0/4] selftests: drv-net: rss_ctx: add tests for RSS contexts Jakub Kicinski
2024-06-25 1:02 ` [PATCH net-next v2 1/4] selftests: drv-net: try to check if port is in use Jakub Kicinski
2024-06-25 6:57 ` Przemek Kitszel
2024-06-25 8:02 ` Breno Leitao
2024-06-25 1:02 ` Jakub Kicinski [this message]
2024-06-25 10:04 ` [PATCH net-next v2 2/4] selftests: drv-net: add helper to wait for HW stats to sync Petr Machata
2024-06-25 1:02 ` [PATCH net-next v2 3/4] selftests: drv-net: add ability to wait for at least N packets to load gen Jakub Kicinski
2024-06-25 8:05 ` Breno Leitao
2024-06-25 8:53 ` Willem de Bruijn
2024-06-25 1:02 ` [PATCH net-next v2 4/4] selftests: drv-net: rss_ctx: add tests for RSS configuration and contexts Jakub Kicinski
2024-06-25 10:42 ` Petr Machata
2024-06-25 13:50 ` Jakub Kicinski
2024-06-25 14:43 ` Petr Machata
2024-06-25 17:06 ` Jakub Kicinski
2024-06-25 17:41 ` Jakub Kicinski
2024-06-26 8:42 ` Petr Machata
2024-06-25 1:40 ` [PATCH net-next v2 0/4] selftests: drv-net: rss_ctx: add tests for RSS contexts Jakub Kicinski
2024-06-25 3:42 ` Michael Chan
2024-06-25 8:52 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240625010210.2002310-3-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.