All of lore.kernel.org
 help / color / mirror / Atom feed
From: max.oss.09@gmail.com
To: openembedded-core@lists.openembedded.org
Cc: Andrey Zhizhikin <andrey.z@gmail.com>,
	Max Krummenacher <max.krummenacher@toradex.com>
Subject: [OE-core][Patch v1] devicetree.bbclass: fix setting S
Date: Tue, 25 Jun 2024 20:30:46 +0200	[thread overview]
Message-ID: <20240625183047.240309-1-max.oss.09@gmail.com> (raw)

From: Max Krummenacher <max.krummenacher@toradex.com>

When a user of devicetree.bbclass overrides setting S, e.g. to
git/overlays then having UNPACKDIR set to S results in that
git repo unpacked inside UNPACKDIR. Thus the sources are actually
in git/overlays/git/overlays rather than the expected git/overlays.

Change the logic, so that S by default is set to UNPACKDIR,
but a user can change S to point to were the sources actually
will be.

Fixes: 7a06069a041a ("devicetree.bbclass: switch away from S = WORKDIR")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 meta/classes-recipe/devicetree.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes-recipe/devicetree.bbclass b/meta/classes-recipe/devicetree.bbclass
index 1806cb62cbf7..e5dbd9a85714 100644
--- a/meta/classes-recipe/devicetree.bbclass
+++ b/meta/classes-recipe/devicetree.bbclass
@@ -40,8 +40,8 @@ PACKAGE_ARCH = "${MACHINE_ARCH}"
 SYSROOT_DIRS += "/boot/devicetree"
 FILES:${PN} = "/boot/devicetree/*.dtb /boot/devicetree/*.dtbo"
 
-S = "${WORKDIR}/sources"
-UNPACKDIR = "${S}"
+UNPACKDIR = "${WORKDIR}/sources"
+S = "${UNPACKDIR}"
 B = "${WORKDIR}/build"
 
 # Default kernel includes, these represent what are normally used for in-kernel
-- 
2.42.0



             reply	other threads:[~2024-06-25 18:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-25 18:30 max.oss.09 [this message]
2024-07-02 13:05 ` [OE-core][Patch v1] devicetree.bbclass: fix setting S Max Krummenacher
2024-07-02 14:08 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240625183047.240309-1-max.oss.09@gmail.com \
    --to=max.oss.09@gmail.com \
    --cc=andrey.z@gmail.com \
    --cc=max.krummenacher@toradex.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.