From: Christoph Hellwig <hch@lst.de>
To: John Meneghini <jmeneghi@redhat.com>
Cc: kbusch@kernel.org, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
emilne@redhat.com, jrani@purestorage.com, randyj@purestorage.com,
chaitanyak@nvidia.com, hare@kernel.org
Subject: Re: [PATCH v8 1/2] nvme-multipath: prepare for "queue-depth" iopolicy
Date: Wed, 26 Jun 2024 07:05:48 +0200 [thread overview]
Message-ID: <20240626050548.GA21922@lst.de> (raw)
In-Reply-To: <20240625122605.857462-2-jmeneghi@redhat.com>
On Tue, Jun 25, 2024 at 08:26:04AM -0400, John Meneghini wrote:
> + struct nvme_ns *old = srcu_dereference(head->current_path[node], &head->srcu);
Please avoid the overly long line here.
> +inline struct nvme_ns *nvme_find_path(struct nvme_ns_head *head)
> +{
> + if (READ_ONCE(head->subsys->iopolicy) == NVME_IOPOLICY_RR)
> + return nvme_round_robin_path(head);
> + else
> + return nvme_numa_path(head);
No need for an else after a return.
next prev parent reply other threads:[~2024-06-26 5:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 12:26 [PATCH v8 0/2] nvme: queue-depth multipath iopolicy John Meneghini
2024-06-25 12:26 ` [PATCH v8 1/2] nvme-multipath: prepare for "queue-depth" iopolicy John Meneghini
2024-06-26 5:05 ` Christoph Hellwig [this message]
2024-06-26 8:02 ` Chaitanya Kulkarni
2024-06-26 8:24 ` Sagi Grimberg
2024-06-25 12:26 ` [PATCH v8 2/2] nvme-multipath: implement " John Meneghini
2024-06-26 5:06 ` Christoph Hellwig
2024-06-26 8:19 ` Chaitanya Kulkarni
2024-06-26 8:24 ` Sagi Grimberg
2024-06-25 16:37 ` [PATCH v8 0/2] nvme: queue-depth multipath iopolicy Keith Busch
2024-06-26 16:54 ` Keith Busch
2024-06-26 17:26 ` Randy Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626050548.GA21922@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=emilne@redhat.com \
--cc=hare@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=jrani@purestorage.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=randyj@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.