From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17E413A88B; Wed, 26 Jun 2024 06:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719382690; cv=none; b=pjvuXJbQBPgMFEbgyoD9SVAZmbBkmjc/CGoA6HncJ3xNrbpEcuPgy4hw4JrnCh8ydjRi/PDPY9TEYZI5hR4n+r2y3Wsvq38zuS3bcEdDnQrz+JCNmAto21VJMeqnc9ItUYFSfZZYGkgH/lWhX/eO66v4CPt8NANZDlFxXw7F2Bc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719382690; c=relaxed/simple; bh=xexNyQLOtrjNiS8Ln7SBcgYZbXn8BHeCquAeOp7gjzA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E7W3sP7bqXx198dStcrPWPWInyvS6AdShbq7DIND7Idf89rQK+d447w4NomX/DzVcvWG9bJoCsconkRGY5NzHVg9IdakQtDX4Waz+Yn6kfYTk8qcd/pXNiC1G8eJ03bMHINNsEfnGAk7X0z+7VEW/iR7l24prCd8vh7O5fvGBBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 85E4B68BEB; Wed, 26 Jun 2024 08:18:04 +0200 (CEST) Date: Wed, 26 Jun 2024 08:18:04 +0200 From: Christoph Hellwig To: Oliver Sang Cc: Christoph Hellwig , oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe , Damien Le Moal , Hannes Reinecke , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression Message-ID: <20240626061804.GA23481@lst.de> References: <202406241546.6bbd44a7-oliver.sang@intel.com> <20240624083537.GA19941@lst.de> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Jun 26, 2024 at 02:11:11PM +0800, Oliver Sang wrote: > hi, Christoph Hellwig, > > On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote: > > This is odd to say at least. Any chance you can check the value > > of /sys/block/$DEVICE/queue/rotational for the relevant device before > > and after this commit? And is this an ATA or NVMe SSD? > > > > yeah, as Niklas mentioned, it's an ATA SSD. > > I checked the /sys/block/$DEVICE/queue/rotational before and after this commit, > both show '0'. not sure if this is expected. > > anyway, I noticed you send a patch [1] > > so I applied this patch upon bd4a633b6f, and found the performance restored. Thanks for testing! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E77DC30658 for ; Wed, 26 Jun 2024 06:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X78Gz/vDvCza3pO7XHkuUyFAPTjJCj8vaICFdLcgmis=; b=fblUR0JQykjfow 6uWujG28VxVBFQs2JYxJ1QCQngR+0hKRJBxdx3bNCls3I+jN/raBINtVg7goxj+r2RA9uVrLBOU4i NHbtrbd6ikpUNPGlT0TEK59HbPgbEkNFiSYH+dGb8Zmsgu8VxRe6/ImOtLPcFhunOOC/kPCQSJOMu qN1vn51TArMGI24ntuJ28vIyqJhEHus6gvBEgHNZ0dOe3SMXtGxWnO5zWGFTWJPO3rt1mXyj1dbhz lZf012X1u6VeFfAovuadLg5se3oZonh0AEbGVmeKUfEETeH+iaQZvzL3mW8M5Ss9Ol8QFhypu9gX4 adeO+8mX54NrWJA0ODUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMLyv-00000005Z72-2Vti; Wed, 26 Jun 2024 06:18:13 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMLys-00000005Z6Q-0smn; Wed, 26 Jun 2024 06:18:11 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 85E4B68BEB; Wed, 26 Jun 2024 08:18:04 +0200 (CEST) Date: Wed, 26 Jun 2024 08:18:04 +0200 From: Christoph Hellwig To: Oliver Sang Cc: Christoph Hellwig , oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe , Damien Le Moal , Hannes Reinecke , linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression Message-ID: <20240626061804.GA23481@lst.de> References: <202406241546.6bbd44a7-oliver.sang@intel.com> <20240624083537.GA19941@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240625_231810_426520_B9A0AA9C X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2024 at 02:11:11PM +0800, Oliver Sang wrote: > hi, Christoph Hellwig, > > On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote: > > This is odd to say at least. Any chance you can check the value > > of /sys/block/$DEVICE/queue/rotational for the relevant device before > > and after this commit? And is this an ATA or NVMe SSD? > > > > yeah, as Niklas mentioned, it's an ATA SSD. > > I checked the /sys/block/$DEVICE/queue/rotational before and after this commit, > both show '0'. not sure if this is expected. > > anyway, I noticed you send a patch [1] > > so I applied this patch upon bd4a633b6f, and found the performance restored. Thanks for testing! ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B964C3064D for ; Wed, 26 Jun 2024 06:18:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W8BNC2rymz3clw for ; Wed, 26 Jun 2024 16:18:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=lists.ozlabs.org) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W8BMl66Ngz30WS for ; Wed, 26 Jun 2024 16:18:11 +1000 (AEST) Received: by verein.lst.de (Postfix, from userid 2407) id 85E4B68BEB; Wed, 26 Jun 2024 08:18:04 +0200 (CEST) Date: Wed, 26 Jun 2024 08:18:04 +0200 From: Christoph Hellwig To: Oliver Sang Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression Message-ID: <20240626061804.GA23481@lst.de> References: <202406241546.6bbd44a7-oliver.sang@intel.com> <20240624083537.GA19941@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, feng.tang@intel.com, linux-nvme@lists.infradead.org, fengwei.yin@intel.com, linux-mtd@lists.infradead.org, linux-bcache@vger.kernel.org, Christoph Hellwig , drbd-dev@lists.linbit.com, linux-s390@vger.kernel.org, lkp@intel.com, linux-scsi@vger.kernel.org, ying.huang@intel.com, xen-devel@lists.xenproject.org, dm-devel@lists.linux.dev, linux-um@lists.infradead.org, virtualization@lists.linux.dev, nbd@other.debian.org, linux-raid@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Damien Le Moal , Hannes Reinecke , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, oe-lkp@lists.linux.dev, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Jun 26, 2024 at 02:11:11PM +0800, Oliver Sang wrote: > hi, Christoph Hellwig, > > On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote: > > This is odd to say at least. Any chance you can check the value > > of /sys/block/$DEVICE/queue/rotational for the relevant device before > > and after this commit? And is this an ATA or NVMe SSD? > > > > yeah, as Niklas mentioned, it's an ATA SSD. > > I checked the /sys/block/$DEVICE/queue/rotational before and after this commit, > both show '0'. not sure if this is expected. > > anyway, I noticed you send a patch [1] > > so I applied this patch upon bd4a633b6f, and found the performance restored. Thanks for testing!