From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
<netdev@vger.kernel.org>, <edumazet@google.com>,
<pabeni@redhat.com>, <willemdebruijn.kernel@gmail.com>,
<leitao@debian.org>, <davem@davemloft.net>
Subject: Re: [RFC net-next 1/2] selftests: drv-net: add ability to schedule cleanup with defer()
Date: Wed, 26 Jun 2024 09:44:15 -0700 [thread overview]
Message-ID: <20240626094415.7ae5afe8@kernel.org> (raw)
In-Reply-To: <87tthg9hvv.fsf@nvidia.com>
On Wed, 26 Jun 2024 11:19:08 +0200 Petr Machata wrote:
> >> There is a global action queue, flushed by ksft_run(). We could support
> >> function level defers too, I guess, but there's no immediate need..
> >
> > That would be a must have for general solution, would it require some
> > boilerplate code at function level?
>
> Presumably you'd need a per-function defer pool.
>
> Which would be naturally modeled as a context manager, but I promised
> myself I'd shut up about that.
No preference on the internal mechanism :)
The part I was unsure about was whether in this case test writer will
want to mix the contexts:
fq = FuncDeferQueue()
fq.defer(...) # this one is called when function exits
defer(...) # this one is global
or not:
defer_func_context()
# any defer after this is assumed to be func-level
defer(...)
so probably best to wait until we have some real examples.
next prev parent reply other threads:[~2024-06-26 16:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 1:36 [RFC net-next 0/2] selftests: drv-net: add ability to schedule cleanup with defer() Jakub Kicinski
2024-06-26 1:36 ` [RFC net-next 1/2] " Jakub Kicinski
2024-06-26 7:43 ` Przemek Kitszel
2024-06-26 9:19 ` Petr Machata
2024-06-26 9:38 ` Przemek Kitszel
2024-06-26 16:44 ` Jakub Kicinski [this message]
2024-06-26 16:49 ` Jakub Kicinski
2024-06-27 8:40 ` Przemek Kitszel
2024-06-27 15:35 ` Jakub Kicinski
2024-06-26 10:18 ` Petr Machata
2024-06-26 16:09 ` Jakub Kicinski
2024-06-27 7:37 ` Petr Machata
2024-06-27 15:41 ` Jakub Kicinski
2024-06-26 1:36 ` [RFC net-next 2/2] selftests: drv-net: rss_ctx: convert to defer() Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626094415.7ae5afe8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leitao@debian.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.